hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov" <apivova...@gmail.com>
Subject Re: Review Request 30437: Implement MONTHS_BETWEEN aligned with Oracle one
Date Fri, 27 Feb 2015 19:38:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30437/#review74555
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
<https://reviews.apache.org/r/30437/#comment121151>

    remove spaces pls



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
<https://reviews.apache.org/r/30437/#comment121153>

    remove spaces pls



ql/src/test/queries/clientpositive/udf_months_between.q
<https://reviews.apache.org/r/30437/#comment121155>

    remove spaces pls 88 89



ql/src/test/results/clientnegative/udf_months_between_error1.q.out
<https://reviews.apache.org/r/30437/#comment121156>

    1st instead of 1-th



ql/src/test/queries/clientpositive/udf_datediff.q
<https://reviews.apache.org/r/30437/#comment121150>

    can you remove spaces pls? lines 90 91



ql/src/test/results/clientnegative/udf_datediff_error1.q.out
<https://reviews.apache.org/r/30437/#comment121158>

    1st instead of 1-th.



ql/src/test/results/clientnegative/udf_datediff_error2.q.out
<https://reviews.apache.org/r/30437/#comment121157>

    1st instead of 1-th


- Alexander Pivovarov


On Feb. 27, 2015, 6:45 p.m., XIAOBING ZHOU wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30437/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 6:45 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is used to track work to build Oracle like months_between. Here's semantics:
> MONTHS_BETWEEN returns number of months between dates date1 and date2. If date1 is later
than date2, then the result is positive. If date1 is earlier than date2, then the result is
negative. If date1 and date2 are either the same days of the month or both last days of months,
then the result is always an integer. Otherwise Oracle Database calculates the fractional
portion of the result based on a 31-day month and considers the difference in time components
date1 and date2.
> 
> https://issues.apache.org/jira/browse/HIVE-9518
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java 403cf11 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiffBase.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMonthsBetween.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFMonthsBetween.java PRE-CREATION

>   ql/src/test/queries/clientnegative/udf_datediff_error1.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_datediff_error2.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_months_between_error1.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_months_between_error2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/udf_datediff.q 30718fe 
>   ql/src/test/queries/clientpositive/udf_months_between.q PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_datediff_error1.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_datediff_error2.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_months_between_error1.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_months_between_error2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out d4b0650 
>   ql/src/test/results/clientpositive/show_functions.q.out.orig d79106f 
>   ql/src/test/results/clientpositive/udf_datediff.q.out 86f30f6 
>   ql/src/test/results/clientpositive/udf_months_between.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30437/diff/
> 
> 
> Testing
> -------
> 
> SEE ALSO ql/src/test/TestGenericUDFMonthsBetween.java
> 
> 
> Thanks,
> 
> XIAOBING ZHOU
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message