hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 31452: HIVE-9781 Utilize spark.kryo.classesToRegister [Spark Branch]
Date Thu, 26 Feb 2015 14:53:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31452/#review74273
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java
<https://reviews.apache.org/r/31452/#comment120817>

    Could we rename this variable for better readability?


- Xuefu Zhang


On Feb. 26, 2015, 1:42 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31452/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 1:42 a.m.)
> 
> 
> Review request for hive, Brock Noland and Xuefu Zhang.
> 
> 
> Bugs: HIVE-9781
>     https://issues.apache.org/jira/browse/HIVE-9781
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference checking is still
needed since there are loops.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 76a4fd1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java f1d65ea

> 
> Diff: https://reviews.apache.org/r/31452/diff/
> 
> 
> Testing
> -------
> 
> Tested it on a yarn cluster with spark.kryo.classesToRegister set.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message