hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "XIAOBING ZHOU" <xzho...@gmail.com>
Subject Review Request 31395: HIVE-9642: Hive metastore client retries don't happen consistently for all api calls
Date Wed, 25 Feb 2015 01:15:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31395/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

When org.apache.thrift.transport.TTransportException is thrown for issues like socket timeout,
the retry via RetryingMetaStoreClient happens only in certain cases.
Retry happens for the getDatabase call in but not for getAllDatabases().
The reason is RetryingMetaStoreClient checks for TTransportException being the cause for InvocationTargetException.
But in case of some calls such as getAllDatabases in HiveMetastoreClient, all exceptions get
wrapped in a MetaException. We should remove this unnecessary wrapping of exceptions for certain
functions in HMC.


Diffs
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java b4f02fc


Diff: https://reviews.apache.org/r/31395/diff/


Testing
-------


Thanks,

XIAOBING ZHOU


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message