hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang" <jxi...@cloudera.com>
Subject Re: Review Request 30739: HIVE-9574 Lazy computing in HiveBaseFunctionResultList may hurt performance [Spark Branch]
Date Tue, 10 Feb 2015 17:24:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30739/
-----------------------------------------------------------

(Updated Feb. 10, 2015, 5:24 p.m.)


Review request for hive, Rui Li and Xuefu Zhang.


Bugs: HIVE-9574
    https://issues.apache.org/jira/browse/HIVE-9574


Repository: hive-git


Description
-------

Result KV cache doesn't use RowContainer any more since it has logic we don't need, which
is some overhead. We don't do lazy computing right away, instead we wait a little till the
cache is close to spill.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java 78ab680

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveKVResultCache.java 8ead0cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 7a09b4d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java e92e299

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java 070ea4d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunctionResultList.java d4ff37c

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 286816b 
  ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestHiveKVResultCache.java 0df4598 

Diff: https://reviews.apache.org/r/30739/diff/


Testing
-------

Unit test, test on cluster


Thanks,

Jimmy Xiang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message