hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov" <apivova...@gmail.com>
Subject Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY
Date Thu, 05 Feb 2015 23:46:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30335/#review71342
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java
<https://reviews.apache.org/r/30335/#comment117023>

    The TRUNC (date) function returns date with the time portion of the day truncated to the
unit specified by the format model fmt.
    If you omit fmt, then date is truncated to the nearest day
    
    SELECT TRUNC('2015-10-27', 'YEAR');
    OK
    '2015-01-01'



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java
<https://reviews.apache.org/r/30335/#comment117022>

    int minDd = 1;  // Always.


- Alexander Pivovarov


On Feb. 5, 2015, 11:33 p.m., XIAOBING ZHOU wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30335/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 11:33 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Hive already supports LAST_DAY UDF, in some cases, FIRST_DAY is necessary to do date/timestamp
related computation. This JIRA is to track such an implementation.
> 
> https://issues.apache.org/jira/browse/HIVE-9480
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfb4dc2 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTrunc.java PRE-CREATION

>   ql/src/test/queries/clientnegative/udf_trunc_error1.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_trunc_error2.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_trunc_error3.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_trunc_error4.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_trunc_error5.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/udf_trunc.q PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_trunc_error1.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_trunc_error2.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_trunc_error3.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_trunc_error4.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_trunc_error5.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out e21b54b 
>   ql/src/test/results/clientpositive/udf_trunc.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30335/diff/
> 
> 
> Testing
> -------
> 
> Unit tests done in ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFirstDay.java
> 
> 
> Thanks,
> 
> XIAOBING ZHOU
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message