hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 29961: HIVE-9302 Beeline add jar local to client
Date Wed, 04 Feb 2015 02:40:16 GMT


> On Feb. 3, 2015, 11:18 p.m., Sergio Pena wrote:
> >

Thanks Sergio for your comments. I will update my patch according to your comments.


> On Feb. 3, 2015, 11:18 p.m., Sergio Pena wrote:
> > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java, line 41
> > <https://reviews.apache.org/r/29961/diff/3/?file=834009#file834009line41>
> >
> >     Could you use a better name for this?

Sorry, I didn't find one. Do you have any idea about it?


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29961/#review70845
-----------------------------------------------------------


On Jan. 26, 2015, 2:57 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29961/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 2:57 a.m.)
> 
> 
> Review request for hive, Brock Noland, Dong Chen, and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support adding local driver jar file in the beeline side and add unit test for it
> 
> 
> Diffs
> -----
> 
>   LICENSE c973c36 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 630ead4 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java 065eab4 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 291adba 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 8ba0232 
>   beeline/src/main/resources/BeeLine.properties d038d46 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java a6ee93a 
>   beeline/src/test/resources/DummyDriver-1.0-SNAPSHOT.jar PRE-CREATION 
>   beeline/src/test/resources/postgresql-9.3.jdbc3.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29961/diff/
> 
> 
> Testing
> -------
> 
> Manullay test done.
> Newly added test passed.
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message