hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 30254: HIVE-9444
Date Tue, 03 Feb 2015 20:47:13 GMT


> On Feb. 3, 2015, 8:20 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java, line 155
> > <https://reviews.apache.org/r/30254/diff/4/?file=846475#file846475line155>
> >
> >     How are we handling subclassess. i.e caller specified both parent class and
child class ?
> >     
> >     Will it belong to two buckets or the first one?
> >     We may want to call out the behavior. May we just document that the API won't
handle Parent, child classes both being specified. An assertion/exception would be nice.

In this case, it will belong to both.

I think it makes sense that the method handles Parent classes, e.g. assume we want to retrieve
all the Join operators in the tree, independently of them being JoinOperator, MapJoinOperator,
SMBMapJoinOperator, etc.; or all the join operators, and at the same time separate them following
some hierarchy. 

But I agree a comment should be added about the behaviour when an operator implements more
than one class; I'll do it right now.


- Jesús


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30254/#review70819
-----------------------------------------------------------


On Feb. 3, 2015, 7:51 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30254/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 7:51 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9444
>     https://issues.apache.org/jira/browse/HIVE-9444
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-9444
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 4d9d1da77394125cfcb9ac9ccf1c00528664b981

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java c9848dacd1a02db321583c2b91eb6d7317c295ff

>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java f031b281ff64706cdbbc1695a6f51282127487fa

>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 43f8321107304c38ecd9f603cd3f8ce43e8496c8

> 
> Diff: https://reviews.apache.org/r/30254/diff/
> 
> 
> Testing
> -------
> 
> Existing tests (global_limit.q).
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message