Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43582177AC for ; Tue, 27 Jan 2015 01:05:36 +0000 (UTC) Received: (qmail 56767 invoked by uid 500); 27 Jan 2015 01:05:35 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56704 invoked by uid 500); 27 Jan 2015 01:05:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56664 invoked by uid 500); 27 Jan 2015 01:05:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 56652 invoked by uid 99); 27 Jan 2015 01:05:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 01:05:34 +0000 Date: Tue, 27 Jan 2015 01:05:34 +0000 (UTC) From: "Ferdinand Xu (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-9470) Use a generic writable object to run ColumnaStorageBench write/read tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-9470?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14292= 772#comment-14292772 ]=20 Ferdinand Xu commented on HIVE-9470: ------------------------------------ LGTM with some minor suggestions. {noformat} 131=09 public ColumnarStorageBench() { {noformat} Please remove extra space. {noformat} 233=09 private ObjectInspector getParquetObjectInspector(final String colu= mnTypes) { {noformat} Can you rename it with getArrayWritableObjectInspector since it will be use= d by both parquet and orc? {noformat} 242=09 Writable parquetWritable =3D createRecord(TypeInfoUtils.getTypeIn= fosFromTypeString(columnTypes)); {noformat} Can you rename it with recordWritable for the same reason as above? > Use a generic writable object to run ColumnaStorageBench write/read tests= =20 > -------------------------------------------------------------------------= - > > Key: HIVE-9470 > URL: https://issues.apache.org/jira/browse/HIVE-9470 > Project: Hive > Issue Type: Improvement > Reporter: Sergio Pe=C3=B1a > Assignee: Sergio Pe=C3=B1a > Attachments: HIVE-9470.1.patch > > > The ColumnarStorageBench benchmark class is using a Parquet writable obje= ct to run all write/read/serialize/deserialize tests. It would be better to= use a more generic writable object (like text writables) to get better ben= chmark results between format storages. > Using parquet writables may add advantage when writing parquet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)