Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Wed, 21 Jan 2015 22:53:34 +0000 (UTC)
From: "Thejas M Nair (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12769109.1421874551000.139438.1421880814679@Atlassian.JIRA>
In-Reply-To: <JIRA.12769109.1421874551000@Atlassian.JIRA>
References: <JIRA.12769109.1421874551000@Atlassian.JIRA>
 <JIRA.12769109.1421874551929@arcas>
Subject: [jira] [Commented] (HIVE-9436) RetryingMetaStoreClient does not
 retry JDOExceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286475#comment-14286475 ] 

Thejas M Nair commented on HIVE-9436:
-------------------------------------

+1

> RetryingMetaStoreClient does not retry JDOExceptions
> ----------------------------------------------------
>
>                 Key: HIVE-9436
>                 URL: https://issues.apache.org/jira/browse/HIVE-9436
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0, 0.13.1
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-9436.patch
>
>
> RetryingMetaStoreClient has a bug in the following bit of code:
> {code}
>         } else if ((e.getCause() instanceof MetaException) &&
>             e.getCause().getMessage().matches("JDO[a-zA-Z]*Exception")) {
>           caughtException = (MetaException) e.getCause();
>         } else {
>           throw e.getCause();
>         }
> {code}
> The bug here is that java String.matches matches the entire string to the regex, and thus, that match will fail if the message contains anything before or after JDO[a-zA-Z]\*Exception. The solution, however, is very simple, we should match .\*JDO[a-zA-Z]\*Exception.\*


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)