Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 260F717480 for ; Mon, 19 Jan 2015 14:43:39 +0000 (UTC) Received: (qmail 33231 invoked by uid 500); 19 Jan 2015 14:43:35 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 33088 invoked by uid 500); 19 Jan 2015 14:43:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 32814 invoked by uid 500); 19 Jan 2015 14:43:35 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 32776 invoked by uid 99); 19 Jan 2015 14:43:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jan 2015 14:43:35 +0000 Date: Mon, 19 Jan 2015 14:43:35 +0000 (UTC) From: "Xuefu Zhang (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (HIVE-9336) Fix Hive throws ParseException while handling Grouping-Sets clauses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-9336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated HIVE-9336: ------------------------------ Comment: was deleted (was: [~xuefuz] I rerun the unit tests through the following commands and all report successed without any errors, So I guess that there are some differences between my local environment and Hive QA's, or we do not pass the same options to mvn when compile and run unit tests, or anything else, Could you help me to find what happened? cd itests mvn test -Dtest=rg.apache.hadoop.hive.cli.TestMinimrCliDriver -Dqfile=index_bitmap_auto.q -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hadoop.hive.cli.TestMinimrCliDriver#testCliDriver_index_bitmap_auto -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hadoop.hive.cli.TestSparkCliDriver -Dqfile=optimize_nullscan.q -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hadoop.hive.cli.TestSparkCliDriver#testCliDriver_optimize_nullscan -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testRemoteClient -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testCounters -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testAddJarsAndFiles -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testSimpleSparkJob -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testErrorJob -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testJobSubmission -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hive.spark.client.TestSparkClient#testMetricsCollection -Dtest.silent=false -Phadoop-2 mvn test -Dtest=org.apache.hadoop.hive.ql.TestMTQueries#testMTQueries1 -Dtest.silent=false -Phadoop-2) > Fix Hive throws ParseException while handling Grouping-Sets clauses > ------------------------------------------------------------------- > > Key: HIVE-9336 > URL: https://issues.apache.org/jira/browse/HIVE-9336 > Project: Hive > Issue Type: Bug > Components: Parser > Affects Versions: 0.13.1 > Reporter: zhaohm3 > Fix For: 0.14.0 > > Attachments: Fix-Hive-ParseException-of-Grouping-Sets.htm, HIVE-9336.1.patch > > > Currently, when Hive parses GROUPING SETS clauses, and if there are some expressions that were composed of two or more common subexpressions, then the first element of those expressions can only be a simple Identifier without any qualifications, otherwise Hive will throw ParseException during its parser stage. Therefore, Hive will throw ParseException while parsing the following HQLs: > {code} > drop table test; > create table test(tc1 int, tc2 int, tc3 int); > > explain select test.tc1, test.tc2 from test group by test.tc1, test.tc2 grouping sets(test.tc1, (test.tc1, test.tc2)); > explain select tc1+tc2, tc2 from test group by tc1+tc2, tc2 grouping sets(tc2, (tc1 + tc2, tc2)); > > drop table test; > {code} > The following contents show some ParseExctption stacktrace: > {code} > 2015-01-07 09:53:34,718 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogBegin(108)) - > 2015-01-07 09:53:34,719 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogBegin(108)) - > 2015-01-07 09:53:34,721 INFO [main]: ql.Driver (Driver.java:checkConcurrency(158)) - Concurrency mode is disabled, not creating a lock manager > 2015-01-07 09:53:34,721 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogBegin(108)) - > 2015-01-07 09:53:34,724 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogBegin(108)) - > 2015-01-07 09:53:34,724 INFO [main]: parse.ParseDriver (ParseDriver.java:parse(185)) - Parsing command: explain select test.tc1, test.tc2 from test group by test.tc1, test.tc2 grouping sets(test.tc1, (test.tc1, test.tc2)) > 2015-01-07 09:53:34,734 ERROR [main]: ql.Driver (SessionState.java:printError(545)) - FAILED: ParseException line 1:105 missing ) at ',' near '' > line 1:116 extraneous input ')' expecting EOF near '' > org.apache.hadoop.hive.ql.parse.ParseException: line 1:105 missing ) at ',' near '' > line 1:116 extraneous input ')' expecting EOF near '' > at org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:210) > at org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:166) > at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:404) > at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:322) > at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:975) > at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1040) > at org.apache.hadoop.hive.ql.Driver.run(Driver.java:911) > at org.apache.hadoop.hive.ql.Driver.run(Driver.java:901) > at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:268) > at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:220) > at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:423) > at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:792) > at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:686) > at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:625) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.apache.hadoop.util.RunJar.main(RunJar.java:208) > 2015-01-07 09:53:34,745 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogEnd(135)) - > 2015-01-07 09:53:34,745 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogBegin(108)) - > 2015-01-07 09:53:34,746 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogEnd(135)) - > 2015-01-07 09:53:34,746 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogBegin(108)) - > 2015-01-07 09:53:34,746 INFO [main]: log.PerfLogger (PerfLogger.java:PerfLogEnd(135)) - > {code} > But, Hive will not throw ParseException while handling the follwing HQLs: > {code} > drop table test; > create table test(tc1 int, tc2 int, tc3 int); > > explain select tc1, test.tc2 from test group by tc1, test.tc2 grouping sets(tc1, (tc1, test.tc2)); > explain select tc1+tc2, tc1 from test group by tc1+tc2, tc1 grouping sets(tc1, (tc1, tc1 + tc2)); > explain select test.tc1, test.tc1 + test.tc2 from test group by test.tc1, test.tc1 + test.tc2 grouping sets(test.tc1, (test.tc1), (test.tc1 + test.tc2)); > > drop table test; > {code} > For why and how to solve it, see the attachments: Fix-Hive-ParseException-of-Grouping-Sets.htm and HIVE-9336.1.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)