Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A8E1DC9C2 for ; Sun, 11 Jan 2015 02:52:34 +0000 (UTC) Received: (qmail 45888 invoked by uid 500); 11 Jan 2015 02:52:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 45802 invoked by uid 500); 11 Jan 2015 02:52:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 45788 invoked by uid 500); 11 Jan 2015 02:52:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 45785 invoked by uid 99); 11 Jan 2015 02:52:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Jan 2015 02:52:34 +0000 Date: Sun, 11 Jan 2015 02:52:34 +0000 (UTC) From: "Szehon Ho (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-9335) Address review items on HIVE-9257 [Spark Branch] MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272773#comment-14272773 ] Szehon Ho commented on HIVE-9335: --------------------------------- +1 looks good to me, thanks for these fixes! > Address review items on HIVE-9257 [Spark Branch] > ------------------------------------------------ > > Key: HIVE-9335 > URL: https://issues.apache.org/jira/browse/HIVE-9335 > Project: Hive > Issue Type: Sub-task > Components: Spark > Affects Versions: spark-branch > Reporter: Brock Noland > Assignee: Brock Noland > Attachments: HIVE-9335.1-spark.patch > > > I made a pass through HIVE-9257 and found the following issues: > {{HashTableSinkOperator.java}} > The fields EMPTY_OBJECT_ARRAY and EMPTY_ROW_CONTAINER are no longer constants and should not be in upper case. > {{HivePairFlatMapFunction.java}} > We share NumberFormat accross threads and it's not thread safe. > {{KryoSerializer.java}} > we eat the stack trace in deserializeJobConf > {{SparkMapRecordHandler}} > in processRow we should not be using {{StringUtils.stringifyException}} since LOG can handle stack traces. > in close: > {noformat} > // signal new failure to map-reduce > LOG.error("Hit error while closing operators - failing tree"); > throw new IllegalStateException("Error while closing operators", e); > {noformat} > Should be: > {noformat} > String msg = "Error while closing operators: " + e; > throw new IllegalStateException(msg, e); > {noformat} > {{SparkSessionManagerImpl}} - the method {{canReuseSession}} is useless > {{GenSparkSkewJoinProcessor}} > {noformat} > + // keep it as reference in case we need fetch work > +// localPlan.getAliasToFetchWork().put(small_alias.toString(), > +// new FetchWork(tblDir, tableDescList.get(small_alias))); > {noformat} > {{GenSparkWorkWalker}} trim ws > {{SparkCompiler}} remote init > {{SparkEdgeProperty}} trim ws > {{CounterStatsPublisher}} eat exception > {{Hadoop23Shims}} unused import of {{ResourceBundles}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)