Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5133C179B9 for ; Sat, 31 Jan 2015 21:40:07 +0000 (UTC) Received: (qmail 22705 invoked by uid 500); 31 Jan 2015 21:40:07 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 22623 invoked by uid 500); 31 Jan 2015 21:40:07 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 22605 invoked by uid 99); 31 Jan 2015 21:40:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Jan 2015 21:40:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F35271CC190; Sat, 31 Jan 2015 21:40:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5986939021207529993==" MIME-Version: 1.0 Subject: Re: Review Request 29898: HIVE-9298: Support reading alternate timestamp formats From: "Ashutosh Chauhan" To: "Ashutosh Chauhan" Cc: "Jason Dere" , "hive" Date: Sat, 31 Jan 2015 21:40:10 -0000 Message-ID: <20150131214010.1308.35531@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29898/ X-Sender: "Ashutosh Chauhan" References: <20150131022545.1308.12630@reviews.apache.org> In-Reply-To: <20150131022545.1308.12630@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============5986939021207529993== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29898/#review70512 ----------------------------------------------------------- Ship it! Ship It! - Ashutosh Chauhan On Jan. 31, 2015, 2:25 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29898/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2015, 2:25 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-9298 > https://issues.apache.org/jira/browse/HIVE-9298 > > > Repository: hive-git > > > Description > ------- > > Add new SerDe parameter "timestamp.formats" to specify alternate timestamp patterns > > > Diffs > ----- > > common/pom.xml ccd4c2c > common/src/java/org/apache/hive/common/util/HiveStringUtils.java 8db2c2c > common/src/java/org/apache/hive/common/util/TimestampParser.java PRE-CREATION > common/src/test/org/apache/hive/common/util/TestHiveStringUtils.java PRE-CREATION > common/src/test/org/apache/hive/common/util/TestTimestampParser.java PRE-CREATION > data/files/ts_formats.txt PRE-CREATION > hbase-handler/src/java/org/apache/hadoop/hive/hbase/DefaultHBaseKeyFactory.java 98bc73f > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java 78f23cb > hbase-handler/src/java/org/apache/hadoop/hive/hbase/struct/AvroHBaseValueFactory.java a2ba827 > hbase-handler/src/java/org/apache/hadoop/hive/hbase/struct/DefaultHBaseValueFactory.java e60b844 > hbase-handler/src/test/queries/positive/hbase_timestamp_format.q PRE-CREATION > hbase-handler/src/test/results/positive/hbase_timestamp_format.q.out PRE-CREATION > pom.xml ecec5af > ql/pom.xml 87f79e2 > ql/src/test/queries/clientpositive/timestamp_formats.q PRE-CREATION > ql/src/test/results/clientpositive/timestamp_formats.q.out PRE-CREATION > serde/if/serde.thrift 76f95b5 > serde/src/gen/thrift/gen-cpp/serde_constants.h 1455382 > serde/src/gen/thrift/gen-cpp/serde_constants.cpp bd5c16d > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 8d3595b > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java 1b708dd > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java 07ea8b9 > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java 386fef9 > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/PropValueUnion.java aa56dc9 > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/SetIntString.java 676f2b2 > serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 3c2f0a9 > serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 08ca294 > serde/src/gen/thrift/gen-rb/serde_constants.rb 40375f5 > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroLazyObjectInspector.java 2fb1c28 > serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 882c43e > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java e3968a9 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 95e30db > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 27895c5 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyListObjectInspector.java 9d66a78 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyMapObjectInspector.java ee870f5 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 1abd8a5 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java 9611e9f > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java 792a9a2 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyObjectInspectorParameters.java PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyObjectInspectorParametersImpl.java PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java 08fec77 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampObjectInspector.java 0d15054 > > Diff: https://reviews.apache.org/r/29898/diff/ > > > Testing > ------- > > Added CliDriver/HBaseCliDriver qfile tests > > > Thanks, > > Jason Dere > > --===============5986939021207529993==--