Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC14617D6C for ; Fri, 30 Jan 2015 02:04:03 +0000 (UTC) Received: (qmail 47806 invoked by uid 500); 30 Jan 2015 02:04:04 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 47727 invoked by uid 500); 30 Jan 2015 02:04:04 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 47714 invoked by uid 99); 30 Jan 2015 02:04:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 02:04:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 291A81D99C9; Fri, 30 Jan 2015 02:03:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6818705078003938762==" MIME-Version: 1.0 Subject: Re: Review Request 30335: Implement FIRST_DAY as compared with LAST_DAY already supported in HIVE From: "XIAOBING ZHOU" To: "XIAOBING ZHOU" , "hive" Date: Fri, 30 Jan 2015 02:03:59 -0000 Message-ID: <20150130020359.25680.54026@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "XIAOBING ZHOU" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30335/ X-Sender: "XIAOBING ZHOU" References: <20150127230600.25679.34424@reviews.apache.org> In-Reply-To: <20150127230600.25679.34424@reviews.apache.org> Reply-To: "XIAOBING ZHOU" X-ReviewRequest-Repository: hive-git --===============6818705078003938762== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ ----------------------------------------------------------- (Updated Jan. 30, 2015, 2:03 a.m.) Review request for hive. Repository: hive-git Description ------- Hive already supports LAST_DAY UDF, in some cases, FIRST_DAY is necessary to do date/timestamp related computation. This JIRA is to track such an implementation. https://issues.apache.org/jira/browse/HIVE-9480 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 23d77ca ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayBase.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFirstDay.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 911ee46 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFirstDay.java PRE-CREATION Diff: https://reviews.apache.org/r/30335/diff/ Testing ------- Unit tests done in GenericUDFFirstDay. Thanks, XIAOBING ZHOU --===============6818705078003938762==--