Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E81E410516 for ; Thu, 29 Jan 2015 01:10:35 +0000 (UTC) Received: (qmail 65536 invoked by uid 500); 29 Jan 2015 01:10:36 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 65471 invoked by uid 500); 29 Jan 2015 01:10:36 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 65440 invoked by uid 99); 29 Jan 2015 01:10:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 01:10:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1DECF1D7CCC; Thu, 29 Jan 2015 01:10:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9218855512919132612==" MIME-Version: 1.0 Subject: Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp From: "Alexander Pivovarov" To: "Thejas Nair" Cc: "Alexander Pivovarov" , "Jason Dere" , "hive" Date: Thu, 29 Jan 2015 01:10:31 -0000 Message-ID: <20150129011031.25679.80510@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alexander Pivovarov" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29900/ X-Sender: "Alexander Pivovarov" References: <20150128232241.25679.98058@reviews.apache.org> In-Reply-To: <20150128232241.25679.98058@reviews.apache.org> Reply-To: "Alexander Pivovarov" X-ReviewRequest-Repository: hive-git --===============9218855512919132612== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/#review70130 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java you can remove " = null". Class attributes in java are null by default - Alexander Pivovarov On Jan. 28, 2015, 11:22 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29900/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 11:22 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-5472 > https://issues.apache.org/jira/browse/HIVE-5472 > > > Repository: hive-git > > > Description > ------- > > Add current_date/current_timestamp. The UDFs get the current_date/timestamp from the SessionState. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b > ql/src/java/org/apache/hadoop/hive/ql/Driver.java ef6db3a > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 23d77ca > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g f412010 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g c960a6b > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c315985 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentTimestamp.java PRE-CREATION > ql/src/test/queries/clientpositive/current_date_timestamp.q PRE-CREATION > ql/src/test/results/clientpositive/current_date_timestamp.q.out PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out 36c8743 > > Diff: https://reviews.apache.org/r/29900/diff/ > > > Testing > ------- > > qfile test added > > > Thanks, > > Jason Dere > > --===============9218855512919132612==--