Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9DEA172EF for ; Tue, 20 Jan 2015 00:37:40 +0000 (UTC) Received: (qmail 3645 invoked by uid 500); 20 Jan 2015 00:37:42 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 3577 invoked by uid 500); 20 Jan 2015 00:37:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 3561 invoked by uid 99); 20 Jan 2015 00:37:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 00:37:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8AFFC1D2C48; Tue, 20 Jan 2015 00:37:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5077589566501465120==" MIME-Version: 1.0 Subject: Re: Review Request 30024: HIVE-9395 Make WAIT_SUBMISSION_TIMEOUT configuable and check timeout in SparkJobMonitor level.[Spark Branch] From: "Lefty Leverenz" To: "Xuefu Zhang" , "Rui Li" Cc: "chengxiang li" , "hive" , "Lefty Leverenz" Date: Tue, 20 Jan 2015 00:37:38 -0000 Message-ID: <20150120003738.9401.88238@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Lefty Leverenz" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30024/ X-Sender: "Lefty Leverenz" References: <20150119081738.9402.74832@reviews.apache.org> In-Reply-To: <20150119081738.9402.74832@reviews.apache.org> Reply-To: "Lefty Leverenz" X-ReviewRequest-Repository: hive-git --===============5077589566501465120== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30024/#review68676 ----------------------------------------------------------- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java please use initial capitals for "Remote" and "Spark" (not your responsibility, I know, but might as well fix it now) common/src/java/org/apache/hadoop/hive/conf/HiveConf.java please use initial capital for "Spark" - Lefty Leverenz On Jan. 19, 2015, 8:17 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30024/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 8:17 a.m.) > > > Review request for hive, Rui Li and Xuefu Zhang. > > > Bugs: HIVE-9395 > https://issues.apache.org/jira/browse/HIVE-9395 > > > Repository: hive-git > > > Description > ------- > > make job submission timeout value configurable and check job submission timeout at SparkJobMonitor level. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 068c962 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java bc409a5 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java 85439e3 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 7c59cf1 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java a8bda6c > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobRef.java cb84556 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobStatus.java cdbc59c > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/LocalSparkJobRef.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobRef.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 85c1ac0 > > Diff: https://reviews.apache.org/r/30024/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > > --===============5077589566501465120==--