Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============4214883942097984992=="
MIME-Version: 1.0
Subject: Re: Review Request 28964: HIVE-8121 Create micro-benchmarks for
 ParquetSerde and evaluate performance
From: "Sergio Pena" <sergio.pena@cloudera.com>
To: "cheng xu" <cheng.a.xu@intel.com>, "Brock Noland" <brock@cloudera.com>
Cc: "hive" <dev@hive.apache.org>, "Sergio Pena" <sergio.pena@cloudera.com>
Date: Wed, 14 Jan 2015 23:47:51 -0000
Message-ID: <20150114234751.23997.29586@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sergio Pena" <noreply@reviews.apache.org>
References: <20150110053120.26559.97028@reviews.apache.org>
In-Reply-To: <20150110053120.26559.97028@reviews.apache.org>
Reply-To: "Sergio Pena" <sergio.pena@cloudera.com>

--===============4214883942097984992==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Ene. 10, 2015, 5:31 a.m., cheng xu wrote:
> > Thank you for your patch!
> > I have a general question about the current solution. Can we add more dimensions to show the performance like throughput, average time? Besides that, I leave some minor issues open.
> > See http://hg.openjdk.java.net/code-tools/jmh/file/1ba1bb91b83c/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_02_BenchmarkModes.java

Thanks Ferd for the review.

I was thinking about adding different dimensions, and I think we should let the developer decide which mode to use. These are the parameters they can use:
$ java -jar target/benchmarks.jar org.apache.hive.benchmark.storage ColumnStorageBench -wi 10 -i 5 -f 2 -bm avgt -tu us

If I add the different dimensions in the code, then JMH will run all the tests with one mode, and then again with the other mode, etc. This may take time.
I prefer to let the developer decide which mode they want to see. I add some comments in the code about the command and parameters they can use
to change the mode.


- Sergio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28964/#review67581
-----------------------------------------------------------


On Ene. 9, 2015, 6:38 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28964/
> -----------------------------------------------------------
> 
> (Updated Ene. 9, 2015, 6:38 p.m.)
> 
> 
> Review request for hive, Brock Noland and cheng xu.
> 
> 
> Bugs: HIVE-8121
>     https://issues.apache.org/jira/browse/HIVE-8121
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is a new tool used to test ORC & PARQUET file format performance.
> 
> 
> Diffs
> -----
> 
>   itests/hive-jmh/pom.xml PRE-CREATION 
>   itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java PRE-CREATION 
>   itests/pom.xml 0a154d6eb8c119e4e6419777c28b59b9d2108ba0 
> 
> Diff: https://reviews.apache.org/r/28964/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>


--===============4214883942097984992==--