Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10178172B3 for ; Tue, 13 Jan 2015 03:48:33 +0000 (UTC) Received: (qmail 456 invoked by uid 500); 13 Jan 2015 03:48:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 372 invoked by uid 500); 13 Jan 2015 03:48:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 354 invoked by uid 99); 13 Jan 2015 03:48:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 03:48:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 173AC1D294A; Tue, 13 Jan 2015 03:48:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2253668473500099910==" MIME-Version: 1.0 Subject: Re: Review Request 29671: Support select distinct * From: "pengcheng xiong" To: "John Pullokkaran" Cc: "pengcheng xiong" , "hive" Date: Tue, 13 Jan 2015 03:48:31 -0000 Message-ID: <20150113034831.23995.57341@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "pengcheng xiong" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29671/ X-Sender: "pengcheng xiong" References: <20150113003149.23995.41407@reviews.apache.org> In-Reply-To: <20150113003149.23995.41407@reviews.apache.org> Reply-To: "pengcheng xiong" X-ReviewRequest-Repository: hive-git --===============2253668473500099910== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29671/ ----------------------------------------------------------- (Updated Jan. 13, 2015, 3:48 a.m.) Review request for hive and John Pullokkaran. Changes ------- address john's comments. Repository: hive-git Description ------- Support select distinct * in operator genaration phase. Diffs (updated) ----- itests/src/test/resources/testconfiguration.properties 917b3a4 ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7 ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714 ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION Diff: https://reviews.apache.org/r/29671/diff/ Testing ------- Thanks, pengcheng xiong --===============2253668473500099910==--