Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B4C5CB58 for ; Sun, 11 Jan 2015 04:14:15 +0000 (UTC) Received: (qmail 3493 invoked by uid 500); 11 Jan 2015 04:14:16 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 3409 invoked by uid 500); 11 Jan 2015 04:14:15 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 3317 invoked by uid 99); 11 Jan 2015 04:14:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Jan 2015 04:14:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 956821CA925; Sun, 11 Jan 2015 04:14:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9027066356973957567==" MIME-Version: 1.0 Subject: Re: Review Request 29494: HIVE-9119: ZooKeeperHiveLockManager does not use zookeeper in the proper way From: "Xuefu Zhang" To: "Szehon Ho" , "Xuefu Zhang" , "Brock Noland" Cc: "Xuefu Zhang" , "Na Yang" , "hive" Date: Sun, 11 Jan 2015 04:14:11 -0000 Message-ID: <20150111041411.26559.24371@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29494/ X-Sender: "Xuefu Zhang" References: <20150105184319.26560.76540@reviews.apache.org> In-Reply-To: <20150105184319.26560.76540@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============9027066356973957567== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29494/#review67606 ----------------------------------------------------------- Ship it! Ship It! - Xuefu Zhang On Jan. 5, 2015, 6:43 p.m., Na Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29494/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 6:43 p.m.) > > > Review request for hive, Brock Noland, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-9119 > https://issues.apache.org/jira/browse/HIVE-9119 > > > Repository: hive-git > > > Description > ------- > > 1. Use singleton ZooKeeper client for ZooKeeperHiveLocManager > 2. Use CuratorFramework to manage ZooKeeper client > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2e51518 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 878202a > ql/pom.xml 84e912e > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/CuratorFrameworkSingleton.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1334a91 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java aacb73f > > Diff: https://reviews.apache.org/r/29494/diff/ > > > Testing > ------- > > > Thanks, > > Na Yang > > --===============9027066356973957567==--