Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D76ACAD2 for ; Sun, 11 Jan 2015 03:44:46 +0000 (UTC) Received: (qmail 81063 invoked by uid 500); 11 Jan 2015 03:44:42 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 80989 invoked by uid 500); 11 Jan 2015 03:44:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 80967 invoked by uid 99); 11 Jan 2015 03:44:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Jan 2015 03:44:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5F6651CA925; Sun, 11 Jan 2015 03:44:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8773317022697206124==" MIME-Version: 1.0 Subject: Re: Review Request 29787: HIVE-9257 : Merge spark to trunk January 2015 (Modified files) From: "Xuefu Zhang" To: "Szehon Ho" , "Xuefu Zhang" , "hive" Date: Sun, 11 Jan 2015 03:44:39 -0000 Message-ID: <20150111034439.26559.46300@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29787/ X-Sender: "Xuefu Zhang" References: <20150109235544.26560.6665@reviews.apache.org> In-Reply-To: <20150109235544.26560.6665@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============8773317022697206124== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29787/#review67603 ----------------------------------------------------------- pom.xml A followup to get rid of this? ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java We should restrain from using * in imports. - Xuefu Zhang On Jan. 9, 2015, 11:55 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29787/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 11:55 p.m.) > > > Review request for hive. > > > Bugs: HIVE-9257 > https://issues.apache.org/jira/browse/HIVE-9257 > > > Repository: hive-git > > > Description > ------- > > As the entire patch is too big, this shows the modified files. These have been cleanuped as part of HIVE-9319, HIVE-9306, HIVE-9305. > > The new files can be found here: http://svn.apache.org/repos/asf/hive/branches/spark/ or https://github.com/apache/hive/tree/spark under: > # data/conf/spark/ > # itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithLocalClusterSpark.java > # itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestMultiSessionsHS2WithLocalClusterSpark.java > # itests/qtest-spark/ > # ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java > # ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ > # ql/src/java/org/apache/hadoop/hive/ql/lib/TypeRule.java > # ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java > # ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenSparkSkewJoinProcessor.java > # ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkCrossProductCheck.java > # ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java > # ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/ > # ql/src/java/org/apache/hadoop/hive/ql/parse/spark/ > # ql/src/java/org/apache/hadoop/hive/ql/plan/SparkBucketMapJoinContext.java > # ql/src/java/org/apache/hadoop/hive/ql/plan/SparkEdgeProperty.java > # ql/src/java/org/apache/hadoop/hive/ql/plan/SparkHashTableSinkDesc.java > # ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java > # ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorSpark.java > # ql/src/test/org/apache/hadoop/hive/ql/exec/spark/ > # ql/src/test/queries/clientpositive/auto_join_stats.q > # ql/src/test/queries/clientpositive/auto_join_stats2.q > # ql/src/test/queries/clientpositive/bucket_map_join_spark1.q > # ql/src/test/queries/clientpositive/bucket_map_join_spark2.q > # ql/src/test/queries/clientpositive/bucket_map_join_spark3.q > # ql/src/test/queries/clientpositive/bucket_map_join_spark4.q > # ql/src/test/queries/clientpositive/multi_insert_mixed.q > # ql/src/test/queries/clientpositive/multi_insert_union_src.q > # ql/src/test/queries/clientpositive/parallel_join0.q > # ql/src/test/queries/clientpositive/parallel_join1.q > # ql/src/test/queries/clientpositive/spark_test.q > # ql/src/test/queries/clientpositive/udf_example_add.q > # ql/src/test/results/clientpositive/auto_join_stats.q.out > # ql/src/test/results/clientpositive/auto_join_stats2.q.out > # ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out > # ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out > # ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out > # ql/src/test/results/clientpositive/bucket_map_join_spark4.q.out > # ql/src/test/results/clientpositive/multi_insert_mixed.q.out > # ql/src/test/results/clientpositive/multi_insert_union_src.q.out > # ql/src/test/results/clientpositive/parallel_join0.q.out > # ql/src/test/results/clientpositive/parallel_join1.q.out > # ql/src/test/results/clientpositive/spark/ > # ql/src/test/results/clientpositive/spark_test.q.out > # ql/src/test/results/clientpositive/udf_example_add.q.out > # spark-client/ > Cleanup and review of those have been done as part of HIVE-9281 and HIVE-9288. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java cd4beeb > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8264b16 > data/conf/hive-log4j.properties a5b9c9a > itests/hive-unit/pom.xml f9f59c9 > itests/pom.xml 0a154d6 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 878202a > pom.xml efe5e3a > ql/pom.xml 84e912e > ql/src/java/org/apache/hadoop/hive/ql/Context.java 0373273 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 8bb6d0f > ql/src/java/org/apache/hadoop/hive/ql/HashTableLoaderFactory.java 10ad933 > ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 3f5f475 > ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java b96faa4 > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java f0e04e7 > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java 561bf3b > ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 87eaa8f > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java e3469a0 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java ed03bb9 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapperContext.java 8b92f32 > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinEagerRowContainer.java 65bb1b7 > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java da36848 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java fd79832 > ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java ac47975 > ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java 4e2b130 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 70c23a6 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java c9e8086 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketJoinProcCtx.java 911b1c8 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 1260c83 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 9a74e1e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java ccb3ce5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 95b678b > ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java 6a7733c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductCheck.java 7ea0166 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java c8e6ef5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcessor.java c973d98 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompilerFactory.java af8e1da > ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 41264f8 > ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java e3cab05 > ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 298a465 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java d566087 > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 57beb69 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ac2cc86 > ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 027bd39 > ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java 0b648aa > ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperators.java 9359a7a > ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java f36f8e0 > ql/src/test/queries/clientpositive/disable_merge_for_bucketing.q 471d296 > ql/src/test/queries/clientpositive/merge1.q c7249af > ql/src/test/queries/clientpositive/merge2.q bb86dc2 > ql/src/test/queries/clientpositive/skewjoin_union_remove_1.q 164dca3 > ql/src/test/queries/clientpositive/skewjoin_union_remove_2.q 9a09849 > ql/src/test/queries/clientpositive/union_remove_1.q c87b3fe > ql/src/test/queries/clientpositive/union_remove_10.q 6701952 > ql/src/test/queries/clientpositive/union_remove_11.q 4b2fa42 > ql/src/test/queries/clientpositive/union_remove_12.q 69d0d0a > ql/src/test/queries/clientpositive/union_remove_13.q 7605f0e > ql/src/test/queries/clientpositive/union_remove_14.q a4fdfc8 > ql/src/test/queries/clientpositive/union_remove_15.q e3c937b > ql/src/test/queries/clientpositive/union_remove_16.q 537078b > ql/src/test/queries/clientpositive/union_remove_17.q d70f3d3 > ql/src/test/queries/clientpositive/union_remove_18.q 6352bc3 > ql/src/test/queries/clientpositive/union_remove_19.q 8d75afa > ql/src/test/queries/clientpositive/union_remove_2.q 83cd288 > ql/src/test/queries/clientpositive/union_remove_20.q f80f7c1 > ql/src/test/queries/clientpositive/union_remove_21.q 8963c25 > ql/src/test/queries/clientpositive/union_remove_22.q b0c1ccd > ql/src/test/queries/clientpositive/union_remove_23.q a1b989a > ql/src/test/queries/clientpositive/union_remove_24.q ec561e0 > ql/src/test/queries/clientpositive/union_remove_25.q 76c1ff5 > ql/src/test/queries/clientpositive/union_remove_3.q 9617f73 > ql/src/test/queries/clientpositive/union_remove_4.q cae323b > ql/src/test/queries/clientpositive/union_remove_5.q 5df84e1 > ql/src/test/queries/clientpositive/union_remove_6.q bfce26d > ql/src/test/queries/clientpositive/union_remove_7.q 3a95674 > ql/src/test/queries/clientpositive/union_remove_8.q a83a43e > ql/src/test/queries/clientpositive/union_remove_9.q e71f6dd > serde/pom.xml 8c60b30 > service/src/java/org/apache/hive/service/server/HiveServer2.java 4dae247 > shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java f881a7a > shims/0.23/pom.xml 924fc1a > shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java f65d394 > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 988692a > > Diff: https://reviews.apache.org/r/29787/diff/ > > > Testing > ------- > > > Thanks, > > Szehon Ho > > --===============8773317022697206124==--