Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 022DE105E2 for ; Fri, 9 Jan 2015 17:51:24 +0000 (UTC) Received: (qmail 88146 invoked by uid 500); 9 Jan 2015 17:51:25 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 88076 invoked by uid 500); 9 Jan 2015 17:51:25 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 88054 invoked by uid 99); 9 Jan 2015 17:51:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2015 17:51:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 630591D0D70; Fri, 9 Jan 2015 17:51:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6181341234393846598==" MIME-Version: 1.0 Subject: Re: Review Request 29702: HIVE-9309 : schematool fails on Postgres 8.1 From: "Brock Noland" To: "Mohit Sabharwal" , "hive" , "Brock Noland" Date: Fri, 09 Jan 2015 17:51:21 -0000 Message-ID: <20150109175121.26561.77437@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29702/ X-Sender: "Brock Noland" References: <20150108081620.26560.14956@reviews.apache.org> In-Reply-To: <20150108081620.26560.14956@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============6181341234393846598== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29702/#review67460 ----------------------------------------------------------- Ship it! Ship It! - Brock Noland On Jan. 8, 2015, 8:16 a.m., Mohit Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29702/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 8:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-9309 > https://issues.apache.org/jira/browse/HIVE-9309 > > > Repository: hive-git > > > Description > ------- > > HIVE-9309 : schematool fails on Postgres 8.1 > > Postgres upgrade scripts set "standard_conforming_strings" which is not allowed in 8.1: > ERROR: parameter "standard_conforming_strings" cannot be changed (state=55P02,code=0) > > Postgres 8.1 Release notes say that "standard_conforming_strings value is read-only" > Postgres 8.2 notes say that it can be set at runtime. > > It'd be nice to address this for those still using Postgres 8.1 > > This patch provides a schemaTool db option "postgres.filter.81" which, if set, filters out the "standard_conforming_strings" statement from upgrade scripts. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java d13d8b67d09704ac8575b8f8bc80192569b06aba > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java 9ae9bc0a267e41a852aa6f87bab532763f9c54b3 > > Diff: https://reviews.apache.org/r/29702/diff/ > > > Testing > ------- > > Added unit test > > > Thanks, > > Mohit Sabharwal > > --===============6181341234393846598==--