hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rui Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9428) LocalSparkJobStatus may return failed job as successful [Spark Branch]
Date Fri, 23 Jan 2015 02:17:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288605#comment-14288605
] 

Rui Li commented on HIVE-9428:
------------------------------

[~xuefuz] - thanks for the review!
1. We have to check Future.isDone() first otherwise Future.get() may block us.
2. Yeah I thought about logging it. Only concern is that the exception may have been logged
already, e.g. spark logs all exceptions during job submission. So it may be redundant. Would
like to know your opinions.

> LocalSparkJobStatus may return failed job as successful [Spark Branch]
> ----------------------------------------------------------------------
>
>                 Key: HIVE-9428
>                 URL: https://issues.apache.org/jira/browse/HIVE-9428
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Rui Li
>            Assignee: Rui Li
>            Priority: Minor
>         Attachments: HIVE-9428.1-spark.patch, HIVE-9428.2-spark.patch
>
>
> Future is done doesn't necessarily mean the job is successful. We should rely on SparkJobInfo
to get job status whenever it's available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message