hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9428) LocalSparkJobStatus may return failed job as successful [Spark Branch]
Date Thu, 22 Jan 2015 14:56:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287538#comment-14287538
] 

Xuefu Zhang commented on HIVE-9428:
-----------------------------------

Patch looks good. However, I'm wondering:

1. Do we need to call both Future.isDone() and Future.get() to get completion status? It seems
calling Future.get() alone is sufficient.
2. Before we eat the exception thrown by Future.get(), could we log it?

> LocalSparkJobStatus may return failed job as successful [Spark Branch]
> ----------------------------------------------------------------------
>
>                 Key: HIVE-9428
>                 URL: https://issues.apache.org/jira/browse/HIVE-9428
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Rui Li
>            Assignee: Rui Li
>            Priority: Minor
>         Attachments: HIVE-9428.1-spark.patch, HIVE-9428.2-spark.patch
>
>
> Future is done doesn't necessarily mean the job is successful. We should rely on SparkJobInfo
to get job status whenever it's available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message