hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9376) Add back some APIs which changed from 0.13 for Spark SQL
Date Wed, 14 Jan 2015 19:39:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277535#comment-14277535
] 

Ashutosh Chauhan commented on HIVE-9376:
----------------------------------------

I have a concern with such a change. Such kind of patch adds tech debt on project. We are
forced to maintain multiple signatures of same method because some other project used an internal
api. Such patching on our side will encourage those projects to make more usage of internal
apis vs using documented public stable apis. I think contract is if any project wants to use
an internal api, they should be ok with its breakage in next hive release. At that point,
they can update the signature to latest hive version, if they chose to support it. Else, they
can use well established shimming technique if they want to continue using internal apis with
multiple hive version support. (Hive itself has done this for long time for hadoop). Providing
guarantees for backward compatibility of any method an external project might chose to use
will dissuade Hive devs to make any changes in hive codebase. Pure refactoring patches which
improves code will be looked down upon, since who knows who might use method getting refactored.


> Add back some APIs which changed from 0.13 for Spark SQL
> --------------------------------------------------------
>
>                 Key: HIVE-9376
>                 URL: https://issues.apache.org/jira/browse/HIVE-9376
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: 0.15.0
>
>         Attachments: HIVE-9376.1.patch
>
>
> As [discussed on HIVE-9364|https://issues.apache.org/jira/browse/HIVE-9364?focusedCommentId=14276100&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14276100]
some APIs were changed which broke SparkSQL. This change adds them back, marks them as Deprecated,
Unstable, and in-use by SparkSQL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message