hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9330) DummyTxnManager will throw NPE if WriteEntity writeType has not been set
Date Fri, 16 Jan 2015 20:06:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280753#comment-14280753
] 

Chaoyu Tang commented on HIVE-9330:
-----------------------------------

The writeType in WriteEntity is default null if not set. I saw a couple of DML cases with
writeType not set which leads to NPE thrown from switch (null). Try to be defensive.

> DummyTxnManager will throw NPE if WriteEntity writeType has not been set
> ------------------------------------------------------------------------
>
>                 Key: HIVE-9330
>                 URL: https://issues.apache.org/jira/browse/HIVE-9330
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Chaoyu Tang
>            Assignee: Chaoyu Tang
>            Priority: Minor
>         Attachments: HIVE-9330.patch, HIVE-9330.patch
>
>
> DummyTxnManager line 259:
> {code}
>     switch (we.getWriteType()) {
>       case DDL_EXCLUSIVE:
>         return HiveLockMode.EXCLUSIVE;
>       case DDL_SHARED:
>         return HiveLockMode.SHARED;
> ...
> {code}
> will throw out NPE in case the WriteEntity(we) writeType has not been set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message