hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9243) Static Map in IOContext is not thread safe
Date Sun, 04 Jan 2015 17:15:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263907#comment-14263907
] 

Xuefu Zhang commented on HIVE-9243:
-----------------------------------

[~brocknoland], the changes look fine, harmless at least, but do you have a repro case that
demonstrates the problem? I think for MR/Tez, the JVM is single threaded (no tasks sharing
the same JVM). We used to have the problem with Spark, but with the latest change, Spark is
only using a thread local for the IOContext object. Therefore, synchronization on the Map
object isn't an issue for Spark either.

> Static Map in IOContext is not thread safe
> ------------------------------------------
>
>                 Key: HIVE-9243
>                 URL: https://issues.apache.org/jira/browse/HIVE-9243
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.15.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: HIVE-9243.patch, HIVE-9243.patch
>
>
> This map can be accessed by multiple threads. We can either map it a {{ConcurrentHashMap}}
or synchronize the calls to this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message