hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9049) Metastore should use TCompactProtocol as opposed to TBinaryProtocol
Date Wed, 07 Jan 2015 22:08:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268350#comment-14268350
] 

Brock Noland commented on HIVE-9049:
------------------------------------

[~ashutoshc] [~prasanth_j],

I understand the reasoning for this change. However this breaks previous versions of clients
from talking with this version of Hive including any custom clients using the thrift API directly.
Of course there are good reasons to make incompatible changes but I am not sure this is the
time. Perhaps we should revert this change or making it configurable, defaulting to off?

Brock

> Metastore should use TCompactProtocol as opposed to TBinaryProtocol
> -------------------------------------------------------------------
>
>                 Key: HIVE-9049
>                 URL: https://issues.apache.org/jira/browse/HIVE-9049
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.15.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: HIVE-9049.1.patch
>
>
> Hive metastore server/client uses TBinaryProtocol. Although binary protocol is better
than simple text/json protocol it is not as effective as TCompactProtocol. TCompactProtocol
is typically more efficient in terms of space and processing (CPU). As seen from this benchmark
TCompactProtocol is better in almost all aspect when compared to TBinaryProtocol
> https://code.google.com/p/thrift-protobuf-compare/wiki/BenchmarkingV2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message