hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8327) mvn site -Pfindbugs
Date Thu, 08 Jan 2015 22:03:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270113#comment-14270113
] 

Gopal V commented on HIVE-8327:
-------------------------------

Yes, all other targets are unaffected.

Before we run regressions on this, we need to get the warnings list to a known-set of false-positives
which we can ignore.

The most critical ones I noticed were classes which implement equals() but not hashCode(),
which when used in a Set<> return bad results.

{code}
org.apache.hadoop.hive.ql.hooks.ReadEntity defines equals but not hashCode	BAD_PRACTICE	HE_EQUALS_NO_HASHCODE
143	Medium
{code}

> mvn site -Pfindbugs
> -------------------
>
>                 Key: HIVE-8327
>                 URL: https://issues.apache.org/jira/browse/HIVE-8327
>             Project: Hive
>          Issue Type: Test
>          Components: Diagnosability
>            Reporter: Gopal V
>            Assignee: Gopal V
>             Fix For: 0.15.0
>
>         Attachments: HIVE-8327.1.patch, HIVE-8327.2.patch, ql-findbugs.html
>
>
> HIVE-3099 originally added findbugs into the old ant build.
> Get basic findbugs working for the maven build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message