hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 29898: HIVE-9298: Support reading alternate timestamp formats
Date Wed, 28 Jan 2015 01:22:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29898/#review69930
-----------------------------------------------------------



common/pom.xml
<https://reviews.apache.org/r/29898/#comment114765>

    Since joda jar will be shipped to task nodes, this needs to be added in hive-exec jar.
I think we keep that list in one of the pom files. We need to add this dep there.



common/src/java/org/apache/hive/common/util/TimestampParser.java
<https://reviews.apache.org/r/29898/#comment114767>

    Name suggests this can be an instance object. If we do that way, than we can avoid creating
this object per invocation, which will be nice if possible.



common/src/java/org/apache/hive/common/util/TimestampParser.java
<https://reviews.apache.org/r/29898/#comment114768>

    Can't we do Long.valueOf()? That will be faster than BD parsing, I presume.



serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
<https://reviews.apache.org/r/29898/#comment114769>

    This is thrift generated file. Instead of hand modifying you need to put this in thrift
file and generate it via thrift compiler.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/29898/#comment114771>

    I wonder why these and lastColtakeRest are not included in LazyOIParams. Seems to me,
they should be included too. If you think otherwise, it will be good to add a comment here
about what distinguishes these two set of params.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/29898/#comment114772>

    I think there is a helper method in apache commons (or guava) which can let you do such
parsing. Will be good to reuse that, if available.


- Ashutosh Chauhan


On Jan. 20, 2015, 12:34 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29898/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 12:34 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-9298
>     https://issues.apache.org/jira/browse/HIVE-9298
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Add new SerDe parameter "timestamp.formats" to specify alternate timestamp patterns
> 
> 
> Diffs
> -----
> 
>   common/pom.xml ede8aea 
>   common/src/java/org/apache/hive/common/util/TimestampParser.java PRE-CREATION 
>   common/src/test/org/apache/hive/common/util/TestTimestampParser.java PRE-CREATION 
>   data/files/ts_formats.txt PRE-CREATION 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/DefaultHBaseKeyFactory.java 98bc73f

>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java 78f23cb

>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/struct/AvroHBaseValueFactory.java
a2ba827 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/struct/DefaultHBaseValueFactory.java
e60b844 
>   hbase-handler/src/test/queries/positive/hbase_timestamp_format.q PRE-CREATION 
>   hbase-handler/src/test/results/positive/hbase_timestamp_format.q.out PRE-CREATION 
>   pom.xml c147d45 
>   ql/src/test/queries/clientpositive/timestamp_formats.q PRE-CREATION 
>   ql/src/test/results/clientpositive/timestamp_formats.q.out PRE-CREATION 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
8d3595b 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroLazyObjectInspector.java 2fb1c28

>   serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 882c43e 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java e3968a9 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 95e30db 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 27895c5 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 3943508 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyListObjectInspector.java
9d66a78 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyMapObjectInspector.java
ee870f5 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
1abd8a5 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
9611e9f 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java
792a9a2 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyObjectInspectorParameters.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyObjectInspectorParametersImpl.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
08fec77 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampObjectInspector.java
0d15054 
> 
> Diff: https://reviews.apache.org/r/29898/diff/
> 
> 
> Testing
> -------
> 
> Added CliDriver/HBaseCliDriver qfile tests
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message