hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 30151: Remove Extract Operator & its friends from codebase.
Date Tue, 27 Jan 2015 02:26:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30151/#review69732
-----------------------------------------------------------


This is huge cleanup. Good work!


ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out
<https://reviews.apache.org/r/30151/#comment114490>

    Any idea why the plan is changed so much?


- Navis Ryu


On Jan. 24, 2015, 6:08 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30151/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 6:08 p.m.)
> 
> 
> Review request for hive and Navis Ryu.
> 
> 
> Bugs: HIVE-9416
>     https://issues.apache.org/jira/browse/HIVE-9416
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Remove Extract Operator & its friends from codebase.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExtractOperator.java c299d3a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java f3c382a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java 2e6a880 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 9ed2c61 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExtractOperator.java 7f4bb64

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
24ca89f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java e16ba6c

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationUtilities.java
dc906e8 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
3fead79 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/OpProcFactory.java d6a6ed6

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/BucketingSortingInferenceOptimizer.java
7954767 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/BucketingSortingOpProcFactory.java
cf02bec 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 94b4621 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 4364f28 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExtractDesc.java 6762155 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SelectDesc.java fa6b548 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 41862e6 
>   ql/src/test/results/clientpositive/bucket1.q.out 13ec735 
>   ql/src/test/results/clientpositive/bucket2.q.out 32a77c3 
>   ql/src/test/results/clientpositive/bucket3.q.out ff7173e 
>   ql/src/test/results/clientpositive/bucket4.q.out b99d12f 
>   ql/src/test/results/clientpositive/bucket5.q.out 5992d6d 
>   ql/src/test/results/clientpositive/bucket6.q.out 5b23d7d 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_1.q.out 75de953 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_2.q.out 599b8b9 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_3.q.out 7456ab0 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out fd99597 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_5.q.out 8130ab9 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_6.q.out 627aba0 
>   ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out 9b058c8 
>   ql/src/test/results/clientpositive/dynpart_sort_opt_vectorization.q.out 32e0745 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 494bfa3 
>   ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_dynamic.q.out
b6e7b88 
>   ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_static.q.out
fc6d2ae 
>   ql/src/test/results/clientpositive/load_dyn_part2.q.out 26f318a 
>   ql/src/test/results/clientpositive/ptf.q.out f678035 
>   ql/src/test/results/clientpositive/ptf_streaming.q.out 9cf645d 
>   ql/src/test/results/clientpositive/smb_mapjoin_20.q.out 999dabd 
>   ql/src/test/results/clientpositive/smb_mapjoin_21.q.out 539b70e 
>   ql/src/test/results/clientpositive/spark/bucket2.q.out 5eb28fa 
>   ql/src/test/results/clientpositive/spark/bucket3.q.out 1b1010a 
>   ql/src/test/results/clientpositive/spark/bucket4.q.out 7dd49ac 
>   ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_2.q.out 365306e

>   ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out 3846de7

>   ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_6.q.out 5b559c4

>   ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out cefc6aa

>   ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_8.q.out ca44d7c

>   ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out 3864c44

>   ql/src/test/results/clientpositive/spark/load_dyn_part2.q.out a8cef34 
>   ql/src/test/results/clientpositive/spark/ptf.q.out ad7d9d5 
>   ql/src/test/results/clientpositive/spark/ptf_streaming.q.out 9f98933 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_20.q.out 9815d24 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_21.q.out 44bae6e 
>   ql/src/test/results/clientpositive/spark/stats10.q.out 4bec7fc 
>   ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out 020fdff 
>   ql/src/test/results/clientpositive/stats10.q.out 804e1b8 
>   ql/src/test/results/clientpositive/tez/bucket2.q.out 9536ed0 
>   ql/src/test/results/clientpositive/tez/bucket3.q.out 3427474 
>   ql/src/test/results/clientpositive/tez/bucket4.q.out ca3584e 
>   ql/src/test/results/clientpositive/tez/disable_merge_for_bucketing.q.out dcffd87 
>   ql/src/test/results/clientpositive/tez/dynpart_sort_opt_vectorization.q.out ad6dbf7

>   ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out ff44a57 
>   ql/src/test/results/clientpositive/tez/load_dyn_part2.q.out d1c4a10 
>   ql/src/test/results/clientpositive/tez/ptf.q.out 6f9dd91 
>   ql/src/test/results/clientpositive/tez/ptf_streaming.q.out a935ef6 
>   ql/src/test/results/clientpositive/tez/vector_bucket.q.out e4deb04 
>   ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out a814849 
>   ql/src/test/results/clientpositive/vector_bucket.q.out 952c033 
>   ql/src/test/results/clientpositive/vectorized_ptf.q.out 1e3c43c 
> 
> Diff: https://reviews.apache.org/r/30151/diff/
> 
> 
> Testing
> -------
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message