hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 28964: HIVE-8121 Create micro-benchmarks for ParquetSerde and evaluate performance
Date Sat, 10 Jan 2015 05:31:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28964/#review67581
-----------------------------------------------------------


Thank you for your patch!
I have a general question about the current solution. Can we add more dimensions to show the
performance like throughput, average time? Besides that, I leave some minor issues open.
See http://hg.openjdk.java.net/code-tools/jmh/file/1ba1bb91b83c/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_02_BenchmarkModes.java


itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111619>

    Please only import the packages you really needed.



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111621>

    The same as above.



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111622>

    The same as above.



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111623>

    Can you sort the import statements in alphabetical order?



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111624>

    Add static here for final variable.



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111625>

    Please add space before and after less-than sign.



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111626>

    Can we add some space here before and after the definition for public method and some
annotations for them?



itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111627>

    No need to break line here.


- cheng xu


On Jan. 9, 2015, 6:38 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28964/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:38 p.m.)
> 
> 
> Review request for hive, Brock Noland and cheng xu.
> 
> 
> Bugs: HIVE-8121
>     https://issues.apache.org/jira/browse/HIVE-8121
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is a new tool used to test ORC & PARQUET file format performance.
> 
> 
> Diffs
> -----
> 
>   itests/hive-jmh/pom.xml PRE-CREATION 
>   itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
PRE-CREATION 
>   itests/pom.xml 0a154d6eb8c119e4e6419777c28b59b9d2108ba0 
> 
> Diff: https://reviews.apache.org/r/28964/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message