hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Review Request 29682: HIVE-9281 : Code cleanup [Spark Branch]
Date Wed, 07 Jan 2015 22:55:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29682/
-----------------------------------------------------------

Review request for hive and Xuefu Zhang.


Bugs: HIVE-9281
    https://issues.apache.org/jira/browse/HIVE-9281


Repository: hive-git


Description
-------

In preparation for merge, we need to cleanup the codes.
This includes removing TODO's, fixing checkstyles, removing commented or unused code, etc.


Diffs
-----

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithLocalClusterSpark.java 7f78a2b

  ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java 15dbe77 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HashTableLoader.java ab8010f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java a84660e

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveKVResultCache.java 93dccd6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 823ea44 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java 74650e8

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HivePairFlatMapFunction.java 1f75cb7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java 9bd305a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunctionResultList.java c153ad8

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClient.java a456d6c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java 78c1da8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 6288ff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java 5cfdcec 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java 87b47a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java e65b4ba 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMergeFileRecordHandler.java 27f6464

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java fb08950 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java ae73f8a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java 08eb4fb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 0a32fff 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReporter.java fdf43f1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java db8bcf6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTran.java c413952 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java b80122b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSession.java 461f359 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManager.java b7ec5f3

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java 2e80383

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java ff65418 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobRef.java d16d1b4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobStatus.java 91ecefa 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkStageProgress.java cfec354

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/JobMetricsListener.java 931ec7f

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/LocalSparkJobStatus.java f66ed42

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 0d03e9d

  ql/src/java/org/apache/hadoop/hive/ql/lib/TypeRule.java b55805c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenSparkSkewJoinProcessor.java
9f54916 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkCrossProductCheck.java f6ca3d0

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 18d1545

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SetSparkReducerParallelism.java 613b5bc

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkJoinHintOptimizer.java 252ab26

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkJoinOptimizer.java 51bdaf4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java 80665ec

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java 113832f

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java 7b69cb7

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java 77a447e

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinResolver.java 354c78c

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinFactory.java 3cee91e

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java fc8021c

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SplitSparkWorkResolver.java 67dda02

  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkProcContext.java 778a5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java f498e9e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java ba855fc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWorkWalker.java ac7b950 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 836704a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkFileSinkProcessor.java 365e538 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java 5a68990

  ql/src/java/org/apache/hadoop/hive/ql/plan/SparkEdgeProperty.java f90acf9 
  ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java 99539c2 
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorSpark.java 03355a3 
  spark-client/src/main/java/org/apache/hive/spark/client/BaseProtocol.java 0fdeff1 
  spark-client/src/main/java/org/apache/hive/spark/client/Job.java 3e2d8c9 
  spark-client/src/main/java/org/apache/hive/spark/client/JobContext.java 68249f9 
  spark-client/src/main/java/org/apache/hive/spark/client/JobContextImpl.java 6a9e8d7 
  spark-client/src/main/java/org/apache/hive/spark/client/JobHandle.java 152899d 
  spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java 7b289cf 
  spark-client/src/main/java/org/apache/hive/spark/client/MetricsCollection.java 6619c88 
  spark-client/src/main/java/org/apache/hive/spark/client/MonitorCallback.java 744b1c3 
  spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java 5aa883f 
  spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java 9757ced 
  spark-client/src/main/java/org/apache/hive/spark/client/SparkClientFactory.java 26b1d46

  spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 54eacfd 
  spark-client/src/main/java/org/apache/hive/spark/client/metrics/InputMetrics.java 7e71d12

  spark-client/src/main/java/org/apache/hive/spark/client/metrics/Metrics.java 28a476b 
  spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java 5149902 
  spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcConfiguration.java 584ee48

  spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java ab8f204 
  spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java 3e44d96 
  spark-client/src/main/java/org/apache/hive/spark/counter/SparkCounters.java 6bf3d63 
  spark-client/src/test/java/org/apache/hive/spark/client/TestMetricsCollection.java f87fc28

  spark-client/src/test/java/org/apache/hive/spark/client/TestSparkClient.java 759be05 
  spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestKryoMessageCodec.java bc9aa43

  spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 8ae45e6 

Diff: https://reviews.apache.org/r/29682/diff/


Testing
-------


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message