hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pengcheng xiong" <pxi...@hortonworks.com>
Subject Re: Review Request 29439: UnionProcessor misses results for multi-insert when hive.optimize.union.remove=true
Date Wed, 07 Jan 2015 02:12:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29439/
-----------------------------------------------------------

(Updated Jan. 7, 2015, 2:12 a.m.)


Review request for hive and John Pullokkaran.


Changes
-------

add notes and test files according to John's comments.


Repository: hive-git


Description
-------

In union_remove_6.q, just change 

FROM (
  SELECT key, count(1) as values from inputTbl1 group by key
  UNION ALL
  SELECT key, count(1) as values from inputTbl1 group by key
) a
insert overwrite table outputTbl1 select *
insert overwrite table outputTbl2 select *;

to 

FROM (
  select * from(
  SELECT key, count(1) as values from inputTbl1 group by key
  UNION ALL
  SELECT key, count(1) as values from inputTbl1 group by key
  )subq
) a
insert overwrite table outputTbl1 select *
insert overwrite table outputTbl2 select *;

select * from outputtbl2 will output nothing


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java a985c4f

  ql/src/test/queries/clientpositive/union_remove_6_subq.q PRE-CREATION 
  ql/src/test/results/clientpositive/union_remove_6_subq.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/29439/diff/


Testing
-------


Thanks,

pengcheng xiong


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message