Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 200DC10B5E for ; Mon, 22 Dec 2014 19:18:15 +0000 (UTC) Received: (qmail 49694 invoked by uid 500); 22 Dec 2014 19:18:14 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 49609 invoked by uid 500); 22 Dec 2014 19:18:14 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 49474 invoked by uid 500); 22 Dec 2014 19:18:14 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 49455 invoked by uid 99); 22 Dec 2014 19:18:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2014 19:18:14 +0000 Date: Mon, 22 Dec 2014 19:18:14 +0000 (UTC) From: "Szehon Ho (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-9181) Fix SkewJoinOptimizer related Java 8 ordering differences MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256065#comment-14256065 ] Szehon Ho commented on HIVE-9181: --------------------------------- +1 Looks good to me, thanks for the tough work. > Fix SkewJoinOptimizer related Java 8 ordering differences > --------------------------------------------------------- > > Key: HIVE-9181 > URL: https://issues.apache.org/jira/browse/HIVE-9181 > Project: Hive > Issue Type: Sub-task > Components: Tests > Reporter: Mohit Sabharwal > Assignee: Mohit Sabharwal > Attachments: HIVE-9181.1.patch, HIVE-9181.patch, HIVE-9181.patch > > > (1) {{SkewJoinOptimizer}} adds items to {{ParseContext.topOps}} is different order in Java 8 vs Java 7. This leads to differences in EXPLAIN output related to {{MapWork}}. > (2) Dbproperties order for a "desc database" query is non-deterministic at the HiveMetastore end between Java 8 and Java 7 (because Thrift maps are un-ordered). > {code} > create database test_db with dbproperties ('key1' = 'value1', 'key2' = 'value2'); > desc database extended test_db; > {code} > At client side, we serialize the dbproperties map returned from HMS as string and write it to a temp file. The {{FetchTask}} then reads the temp file and returns the string back to the user. In test environment, for consistent ordering, we should sort the map before it is serialized to the temp file. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)