Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF03F90B3 for ; Thu, 18 Dec 2014 07:04:39 +0000 (UTC) Received: (qmail 6361 invoked by uid 500); 18 Dec 2014 07:04:39 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 6298 invoked by uid 500); 18 Dec 2014 07:04:39 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 6282 invoked by uid 99); 18 Dec 2014 07:04:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Dec 2014 07:04:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 43AF31D20EC; Thu, 18 Dec 2014 07:04:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7195911471222609671==" MIME-Version: 1.0 Subject: Re: Review Request 29037: Avoid creating serde for partitions if possible in FetchTask From: "Navis Ryu" To: "Navis Ryu" , "hive" Date: Thu, 18 Dec 2014 07:04:38 -0000 Message-ID: <20141218070438.12935.14418@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Navis Ryu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29037/ X-Sender: "Navis Ryu" References: <20141215083743.12934.23203@reviews.apache.org> In-Reply-To: <20141215083743.12934.23203@reviews.apache.org> Reply-To: "Navis Ryu" X-ReviewRequest-Repository: hive-git --===============7195911471222609671== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29037/ ----------------------------------------------------------- (Updated Dec. 18, 2014, 7:04 a.m.) Review request for hive. Bugs: HIVE-7977 https://issues.apache.org/jira/browse/HIVE-7977 Repository: hive-git Description ------- Currently, FetchTask creates SerDe instance thrice for each partition, which can be avoided if it's same with table SerDe. Diffs (updated) ----- data/files/datatypes.txt 0228a27 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1355230 ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 6338c3c ql/src/java/org/apache/hadoop/hive/ql/exec/PartitionKeySampler.java 5d126a5 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java ca65a8e ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 29be691 ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 32d84ea ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 374e8b6 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedListObjectInspector.java 6a9215b serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedMapObjectInspector.java 975d5cd serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedObjectInspectorFactory.java 2db3819 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedStructObjectInspector.java ef66e97 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedUnionObjectInspector.java 521fdd6 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java 8a42577 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 49884b8 Diff: https://reviews.apache.org/r/29037/diff/ Testing ------- Thanks, Navis Ryu --===============7195911471222609671==--