Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 12FB591A3 for ; Tue, 9 Dec 2014 20:41:39 +0000 (UTC) Received: (qmail 64518 invoked by uid 500); 9 Dec 2014 20:41:38 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 64446 invoked by uid 500); 9 Dec 2014 20:41:38 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 64431 invoked by uid 99); 9 Dec 2014 20:41:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 20:41:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 365AD1D2300; Tue, 9 Dec 2014 20:41:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5746420372205670639==" MIME-Version: 1.0 Subject: Re: Review Request 26966: Path type entities should use qualified path rather than string From: "Mohit Sabharwal" To: "Navis Ryu" , "Mohit Sabharwal" , "hive" Date: Tue, 09 Dec 2014 20:41:35 -0000 Message-ID: <20141209204135.26419.39912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mohit Sabharwal" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26966/ X-Sender: "Mohit Sabharwal" References: <20141021065535.1283.1558@reviews.apache.org> In-Reply-To: <20141021065535.1283.1558@reviews.apache.org> Reply-To: "Mohit Sabharwal" X-ReviewRequest-Repository: hive-git --===============5746420372205670639== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review64432 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java Looks like FileUtils.isLocalFile is a 'best effort' check based on URI format. So probably better to just trust the user ? - Mohit Sabharwal On Oct. 21, 2014, 6:55 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26966/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 6:55 a.m.) > > > Review request for hive. > > > Bugs: HIVE-8357 > https://issues.apache.org/jira/browse/HIVE-8357 > > > Repository: hive-git > > > Description > ------- > > Path type entities should use qualified path rather than string > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 95e8d7c > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestCreateUdfEntities.java c60f856 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java e254505 > ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 76b1f01 > ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 8b6a923 > ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java c5be822 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 37cbf7f > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java c060d74 > ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java f96209c > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 22e5b47 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 4891518 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 8bd24d3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d > ql/src/test/results/clientnegative/udf_local_resource.q.out 2f2227b > ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out e184787 > ql/src/test/results/clientpositive/add_part_multiple.q.out 975baa5 > ql/src/test/results/clientpositive/alter2.q.out 3356ab9 > ql/src/test/results/clientpositive/alter5.q.out a83b68d > ql/src/test/results/clientpositive/exim_17_part_managed.q.out 9036a28 > > Diff: https://reviews.apache.org/r/26966/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > > --===============5746420372205670639==--