Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 647019104 for ; Tue, 9 Dec 2014 20:36:51 +0000 (UTC) Received: (qmail 45512 invoked by uid 500); 9 Dec 2014 20:36:51 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 45435 invoked by uid 500); 9 Dec 2014 20:36:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 45420 invoked by uid 99); 9 Dec 2014 20:36:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 20:36:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8AB611D2300; Tue, 9 Dec 2014 20:36:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6587986298045167104==" MIME-Version: 1.0 Subject: Re: Review Request 28864: HIVE-9042 Support multiple mapjoin operators in one work [Spark Branch] From: "Jimmy Xiang" To: "Xuefu Zhang" Cc: "Jimmy Xiang" , "Xuefu Zhang" , "hive" Date: Tue, 09 Dec 2014 20:36:47 -0000 Message-ID: <20141209203647.5766.36629@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jimmy Xiang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/28864/ X-Sender: "Jimmy Xiang" References: <20141209202815.5766.11994@reviews.apache.org> In-Reply-To: <20141209202815.5766.11994@reviews.apache.org> Reply-To: "Jimmy Xiang" X-ReviewRequest-Repository: hive-git --===============6587986298045167104== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 9, 2014, 8:28 p.m., Xuefu Zhang wrote: > > Patch looks a good. A test case with multiple map joins in one work would be awesome. Let me add a test case. Thanks. > On Dec. 9, 2014, 8:28 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 94 > > > > > > There is no need to be "lazy" here. We can just instantiate it here. Just trying to avoid creating an object in case not needed. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28864/#review64428 ----------------------------------------------------------- On Dec. 9, 2014, 7:41 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28864/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 7:41 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-9042 > https://issues.apache.org/jira/browse/HIVE-9042 > > > Repository: hive-git > > > Description > ------- > > In one spark work, there could be multiple mapjoin operators, but only one could be bucket mapjoin. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 6977abc > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java ef04885 > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkBucketMapJoinContext.java 2976c3a > > Diff: https://reviews.apache.org/r/28864/diff/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Jimmy Xiang > > --===============6587986298045167104==--