Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00C7410DE9 for ; Sun, 7 Dec 2014 05:20:57 +0000 (UTC) Received: (qmail 33950 invoked by uid 500); 7 Dec 2014 05:20:56 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 33879 invoked by uid 500); 7 Dec 2014 05:20:56 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 33859 invoked by uid 99); 7 Dec 2014 05:20:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Dec 2014 05:20:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B2DAC1D22AD; Sun, 7 Dec 2014 05:20:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1264421405037824807==" MIME-Version: 1.0 Subject: Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch] From: "Jimmy Xiang" To: "Xuefu Zhang" Cc: "Jimmy Xiang" , "Xuefu Zhang" , "hive" Date: Sun, 07 Dec 2014 05:20:53 -0000 Message-ID: <20141207052053.32526.44056@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jimmy Xiang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/28727/ X-Sender: "Jimmy Xiang" References: <20141205224046.32526.43841@reviews.apache.org> In-Reply-To: <20141205224046.32526.43841@reviews.apache.org> Reply-To: "Jimmy Xiang" X-ReviewRequest-Repository: hive-git --===============1264421405037824807== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 5, 2014, 10:40 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java, line 121 > > > > > > Be aware of different hadoop versions. I checked. Both hadoop 1 and 2 have this API. > On Dec. 5, 2014, 10:40 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java, line 321 > > > > > > Can we have some comments on what this methods do, as it's not trivial? This is changed, so it is simple now. > On Dec. 5, 2014, 10:40 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java, line 342 > > > > > > Do we assume the set always contains only entry? That's a good question. Let me fix this in the next patch. > On Dec. 5, 2014, 10:40 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 96 > > > > > > Are we only get the first instance of such operator? There could be more than one instance in a work. Yes, we get the first instance only. If there could be many instances, we need to fix it. On Dec. 5, 2014, 10:40 p.m., Jimmy Xiang wrote: > > Overall, the patch looks good to me. Besides the comments above, I'm not very confident that I understand enough to let this go in. Maybe a face to face discussion will help. Sure. Let's have a chat. Thanks. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28727/#review64093 ----------------------------------------------------------- On Dec. 4, 2014, 11:38 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28727/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 11:38 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8638 > https://issues.apache.org/jira/browse/HIVE-8638 > > > Repository: hive-git > > > Description > ------- > > Patch v3 that works when bucket number matches > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 09c667e > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java cfc1501 > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java 2f9e55a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 4054173 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkBucketJoinProcCtx.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java 8b78123 > ql/src/test/queries/clientpositive/bucket_map_join_spark1.q PRE-CREATION > ql/src/test/queries/clientpositive/bucket_map_join_spark2.q PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/28727/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > > --===============1264421405037824807==--