hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HIVE-9151) Checking s against null in TezJobMonitor#getNameWithProgress() should be done earlier
Date Wed, 17 Dec 2014 22:26:13 GMT
Ted Yu created HIVE-9151:
----------------------------

             Summary: Checking s against null in TezJobMonitor#getNameWithProgress() should
be done earlier
                 Key: HIVE-9151
                 URL: https://issues.apache.org/jira/browse/HIVE-9151
             Project: Hive
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


{code}
    int spaceRemaining = COLUMN_1_WIDTH - s.length() - 1;
    String trimmedVName = s;

    // if the vertex name is longer than column 1 width, trim it down
    // "Tez Merge File Work" will become "Tez Merge File.."
    if (s != null && s.length() > COLUMN_1_WIDTH) {
{code}
s is dereferenced first, rendering the null check ineffective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message