hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9119) ZooKeeperHiveLockManager does not use zookeeper in the proper way
Date Tue, 30 Dec 2014 09:17:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260937#comment-14260937
] 

Lefty Leverenz commented on HIVE-9119:
--------------------------------------

Thanks for the changes, [~nyang].

One new question:  When you changed the default of *hive.zookeeper.session.timeout* to use
a TimeValidator, did an extra zero slip into the value or was the original not in milliseconds?
 (600*1000 -> 6000000ms.)

Also, you might want to split the description of *hive.zookeeper.connection.basesleeptime*
into two lines.

> ZooKeeperHiveLockManager does not use zookeeper in the proper way
> -----------------------------------------------------------------
>
>                 Key: HIVE-9119
>                 URL: https://issues.apache.org/jira/browse/HIVE-9119
>             Project: Hive
>          Issue Type: Improvement
>          Components: Locking
>    Affects Versions: 0.13.0, 0.14.0, 0.13.1
>            Reporter: Na Yang
>            Assignee: Na Yang
>         Attachments: HIVE-9119.1.patch, HIVE-9119.2.patch
>
>
> ZooKeeperHiveLockManager does not use zookeeper in the proper way. 
> Currently a new zookeeper client instance is created for each getlock/releaselock query
which sometimes causes the number of open connections between
> HiveServer2 and ZooKeeper exceed the max connection number that zookeeper server allows.

> To use zookeeper as a distributed lock, there is no need to create a new zookeeper instance
for every getlock try. A single zookeeper instance could be reused and shared by ZooKeeperHiveLockManagers.
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message