hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9060) Fix child operator references after NonBlockingOpDeDupProc
Date Wed, 10 Dec 2014 20:22:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241662#comment-14241662
] 

Xuefu Zhang commented on HIVE-9060:
-----------------------------------

Patch looks good. One minor comment, it seems cleaner if we iterate over the map's entry set
in the inner for loop. Also, qbJoinTree.getAliasToOpInfo() seems repeated a few times in the
block.
{code}
+      for (String alias : qbJoinTree.getAliasToOpInfo().keySet()) {
+        Operator<? extends OperatorDesc> opInfo = qbJoinTree.getAliasToOpInfo().get(alias);
+        if (opInfo == cSEL) {
+          qbJoinTree.getAliasToOpInfo().put(alias, pSEL);
+        }
{cide}

> Fix child operator references after NonBlockingOpDeDupProc
> ----------------------------------------------------------
>
>                 Key: HIVE-9060
>                 URL: https://issues.apache.org/jira/browse/HIVE-9060
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: HIVE-9060.patch
>
>
> The optimizer proc called 'NonBlockingOpDeDupProc' combines Sel-Sel or Fil-Fil into a
single operator.  However, some references to the old (removed) child still remain in the
optimizer context, and mess up further optimizer procs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message