hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8974) Upgrade to Calcite 1.0.0-SNAPSHOT (with lots of renames)
Date Tue, 02 Dec 2014 18:33:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231877#comment-14231877
] 

Ashutosh Chauhan commented on HIVE-8974:
----------------------------------------

{code}
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveRel.java:[23,8]
class HiveRelNode is public, should be declared in a file named HiveRelNode.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/rules/HivePartitionPrunerRule.java:[30,8]
class HivePartitionPruneRule is public, should be declared in a file named HivePartitionPruneRule.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/rules/PartitionPruner.java:[42,8]
class PartitionPrune is public, should be declared in a file named PartitionPrune.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveFilterRel.java:[31,8]
class HiveFilter is public, should be declared in a file named HiveFilter.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveTableScanRel.java:[43,8]
class HiveTableScan is public, should be declared in a file named HiveTableScan.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java:[47,8]
class HiveProject is public, should be declared in a file named HiveProject.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveLimitRel.java:[32,8]
class HiveLimit is public, should be declared in a file named HiveLimit.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveUnionRel.java:[31,8]
class HiveUnion is public, should be declared in a file named HiveUnion.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/rules/HivePushFilterPastJoinRule.java:[39,17]
class HiveFilterJoinRule is public, should be declared in a file named HiveFilterJoinRule.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/OptiqSemanticException.java:[28,8]
class CalciteSemanticException is public, should be declared in a file named CalciteSemanticException.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveSortRel.java:[33,8]
class HiveSort is public, should be declared in a file named HiveSort.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/rules/HiveMergeProjectRule.java:[24,8]
class HiveProjectMergeRule is public, should be declared in a file named HiveProjectMergeRule.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveJoinRel.java:[40,8]
class HiveJoin is public, should be declared in a file named HiveJoin.java
[ERROR] /data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/HiveOptiqUtil.java:[56,8]
class HiveCalciteUtil is public, should be declared in a file named HiveCalciteUtil.java
{code}

It is the way diff file is generated. git diff is doing rename detection and thus is generating
a patch file which can be applied using git apply, but not with {{patch}} command. You need
to turn off renames in git diff and then generate patch. To replicate Hive QA, do following
:
{code}
$ svn co https://svn.apache.org/repos/asf/hive/trunk .
$ curl https://issues.apache.org/jira/secure/attachment/12684615/HIVE-8974.01.patch | patch
-p1
$ mvn clean install -DskipTests -Phadoop-2
{code}

you will see same errors.
Essentially, you need to generate a patch which can be applied on svn repo with a {patch command}
preferably with option -p0

> Upgrade to Calcite 1.0.0-SNAPSHOT (with lots of renames)
> --------------------------------------------------------
>
>                 Key: HIVE-8974
>                 URL: https://issues.apache.org/jira/browse/HIVE-8974
>             Project: Hive
>          Issue Type: Task
>    Affects Versions: 0.15.0
>            Reporter: Julian Hyde
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 0.15.0
>
>         Attachments: HIVE-8974.01.patch, HIVE-8974.patch
>
>
> CLEAR LIBRARY CACHE
> Calcite recently (after 0.9.2, before 1.0.0) re-organized its package structure and renamed
a lot of classes. CALCITE-296 has the details, including a description of the before:after
mapping.
> This task is to upgrade to the version of Calcite that has the renamed packages. There
is a 1.0.0-SNAPSHOT in Apache nexus.
> Calcite functionality has not changed significantly, so it should be straightforward
to rename. This task should be completed ASAP, before Calcite moves on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message