hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 28941: HIVE-8988
Date Tue, 23 Dec 2014 11:55:39 GMT


> On Dec. 22, 2014, 7:11 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 13456
> > <https://reviews.apache.org/r/28941/diff/6/?file=796676#file796676line13456>
> >
> >     Does Hive support grouping function in the schema?
> >     If so we would need to change the GB output schema to accomodate this, right?
> 
> Jesús Camacho Rodríguez wrote:
>     1) The grouping function column is not added by the Aggregate operator in Calcite,
but by a Project operator that is introduced just above (lines 13715-13762). Thus, the schema
of the Aggregate operator should not contain that column.
>     2) However, I had not added the grouping-indicator columns that are present in Calcite
to the schema in Hive; they are part of the mismatch Hive-Calcite, and thus, they will never
be referenced by other operators in Hive.
>     However, I think it makes sense to add them so the tuples produced by the Aggregate
operators conform to the schema, so I will update the patch.

I have checked about 2), and I think it is better to leave it as it is now, as there is no
corresponding ASTNode for those columns that we could add to the RowResolver.


- Jesús


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28941/#review65809
-----------------------------------------------------------


On Dec. 18, 2014, 11:07 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28941/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 11:07 p.m.)
> 
> 
> Review request for hive, John Pullokkaran and Julian Hyde.
> 
> 
> Bugs: HIVE-8988
>     https://issues.apache.org/jira/browse/HIVE-8988
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8988
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
c02a65e2041e4742a56cf4a935da0a7c04d18fdb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 29be69182667dbe2070bd092bf75b4bb97101554

>   ql/src/test/queries/clientpositive/groupby_cube1.q c12720b27059075050fc92d9f31420c081303699

>   ql/src/test/queries/clientpositive/groupby_grouping_sets6.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 4f48aef2f7f6a809da6ba68d2d98afc312015baa

>   ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out bcc5745a8a6d5619f656ae3f858a5cd230d3d9c2

>   ql/src/test/results/clientpositive/groupby_cube1.q.out 7b5d70ae8ffce47a4b351ed9dfedcd15ab1e139c

>   ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 7c88a67e377fe92cd4ecbd6e1ec12cd541d98bba

>   ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 6ae6e551eb7646bc81d32f135c551ff68901d6e3

>   ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out cf1515c129d7d8e945fbe7904e01710749220ef4

>   ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/groupby_rollup1.q.out bc77aeaf2a56561a03227ea47bd93ed93d95996e

>   ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 044946f4242599a3db3b7a7b5a2538d647370052

> 
> Diff: https://reviews.apache.org/r/28941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message