hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pengcheng xiong" <pxi...@hortonworks.com>
Subject Re: Review Request 28797: Support Union Distinct
Date Mon, 22 Dec 2014 21:23:59 GMT


> On Dec. 22, 2014, 8:37 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/QBExpr.java, line 42
> > <https://reviews.apache.org/r/28797/diff/3/?file=797306#file797306line42>
> >
> >     Why don't we make it a boolean for ALL/Distinct?

Because HiveParser.TOK_UNIONALL and HiveParser.TOK_UNIONDISTINCT are all integers for convenience
purpose.


- pengcheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28797/#review65814
-----------------------------------------------------------


On Dec. 19, 2014, 6:28 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28797/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 6:28 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Current version (Hive 0.14) does not support union (or union distinct). It only supports
union all. In this patch, we try to add this new feature by rewriting union distinct to union
all followed by group by.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 1e67a67 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
c02a65e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 4e98e9b 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBExpr.java e923bca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 29be691 
>   ql/src/test/queries/clientpositive/unionDistinct_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/unionDistinct_2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/explain_logical.q.out 41c8a2b 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out cb94faa 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out bbc0de4 
>   ql/src/test/results/clientpositive/input_part7.q.out 6094f9c 
>   ql/src/test/results/clientpositive/join34.q.out e053e44 
>   ql/src/test/results/clientpositive/join35.q.out 579920b 
>   ql/src/test/results/clientpositive/optimize_nullscan.q.out fb66f5e 
>   ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out e598191 
>   ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/unionDistinct_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/union22.q.out 672fa77 
>   ql/src/test/results/clientpositive/union24.q.out 8755025 
>   ql/src/test/results/clientpositive/unionDistinct_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/unionDistinct_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/union_ppr.q.out 0610337 
> 
> Diff: https://reviews.apache.org/r/28797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message