hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 28933: HIVE-8131:Support timestamp in Avro
Date Tue, 16 Dec 2014 02:57:11 GMT


> On Dec. 12, 2014, 4:30 a.m., Dong Chen wrote:
> > data/files/avro_timestamp.txt, line 4
> > <https://reviews.apache.org/r/28933/diff/1/?file=789138#file789138line4>
> >
> >     how about add some other formats?

We can use timestamp with the precision of millis instead.


> On Dec. 12, 2014, 4:30 a.m., Dong Chen wrote:
> > serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java, line
268
> > <https://reviews.apache.org/r/28933/diff/1/?file=789146#file789146line268>
> >
> >     We check TypeInfo -> Schema here. Can we also check Schema -> TypeInfo
?

This may be out of the scope of TestTypeInfoToSchema.java.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28933/#review64857
-----------------------------------------------------------


On Dec. 11, 2014, 5:57 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28933/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 5:57 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The patch includes:
> 1.add timestamp support for AvroSerde 
> 2.add related test cases
> 
> 
> Diffs
> -----
> 
>   data/files/avro_timestamp.txt PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_timestamp.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_timestamp.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 07c5ecf 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 7639a2b 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java c8eac89 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java c84b1a0 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 8cb2dc3 
>   serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java cd5a0fa

> 
> Diff: https://reviews.apache.org/r/28933/diff/
> 
> 
> Testing
> -------
> 
> Test passed for added cases
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message