hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohit Sabharwal" <mo...@cloudera.com>
Subject Re: Review Request 28933: HIVE-8131:Support timestamp in Avro
Date Sun, 14 Dec 2014 07:50:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28933/#review65039
-----------------------------------------------------------



ql/src/test/results/clientpositive/avro_timestamp.q.out
<https://reviews.apache.org/r/28933/#comment107977>

    Looks like we are truncating the timestamp from millis to nanos because Avro spec expects
millis.
    
    Any idea why the precision for the partition timestamp column is printed in nanos whenever
timestamp is in where clause ? 
    
    Also maybe add another query in the test with millis in the where clause ?



serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java
<https://reviews.apache.org/r/28933/#comment107976>

    should be timestamp-milllis per the spec...



serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
<https://reviews.apache.org/r/28933/#comment107975>

    Shouldn't the logical type be "timestamp-millis" according to Avro spec ?
     
    See: https://issues.apache.org/jira/secure/attachment/12663245/AVRO-739-update-spec.diff



serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
<https://reviews.apache.org/r/28933/#comment107974>

    "Test for timestamp" instead of "Test for date"


- Mohit Sabharwal


On Dec. 11, 2014, 5:57 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28933/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 5:57 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The patch includes:
> 1.add timestamp support for AvroSerde 
> 2.add related test cases
> 
> 
> Diffs
> -----
> 
>   data/files/avro_timestamp.txt PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_timestamp.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_timestamp.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 07c5ecf 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 7639a2b 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java c8eac89 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java c84b1a0 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 8cb2dc3 
>   serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java cd5a0fa

> 
> Diff: https://reviews.apache.org/r/28933/diff/
> 
> 
> Testing
> -------
> 
> Test passed for added cases
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message