hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergio Pena" <sergio.p...@cloudera.com>
Subject Re: Review Request 28964: HIVE-8121 Create micro-benchmarks for ParquetSerde and evaluate performance
Date Thu, 11 Dec 2014 21:45:40 GMT


> On Dic. 11, 2014, 8:16 p.m., Brock Noland wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveStoragePerformance.java, line 105
> > <https://reviews.apache.org/r/28964/diff/1/?file=789655#file789655line105>
> >
> >     Since we don't actually use the data, should we just re-use the same value?
That way we won't get the noise of allocating memory for new objects?

I am just doing it the way that MR would do when getting the K,V information. I am not sure
what would happen wether we pass the same object over and over, then the RecordReader will
behave different and get different results. I need a little extra help here to understands
why next() needs the V object.


- Sergio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28964/#review64785
-----------------------------------------------------------


On Dic. 11, 2014, 7:48 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28964/
> -----------------------------------------------------------
> 
> (Updated Dic. 11, 2014, 7:48 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-8121
>     https://issues.apache.org/jira/browse/HIVE-8121
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is a new tool used to test ORC & PARQUET file format performance.
> 
> 
> Diffs
> -----
> 
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveStoragePerformance.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/28964/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message