hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohit Sabharwal" <mo...@cloudera.com>
Subject Re: Review Request 26966: Path type entities should use qualified path rather than string
Date Tue, 09 Dec 2014 20:41:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26966/#review64432
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
<https://reviews.apache.org/r/26966/#comment107141>

    Looks like FileUtils.isLocalFile is a 'best effort' check based on URI format. So probably
better to just trust the user ?


- Mohit Sabharwal


On Oct. 21, 2014, 6:55 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26966/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 6:55 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-8357
>     https://issues.apache.org/jira/browse/HIVE-8357
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Path type entities should use qualified path rather than string
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java 95e8d7c 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestCreateUdfEntities.java
c60f856 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java e254505 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 76b1f01 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 8b6a923 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java c5be822 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 37cbf7f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java c060d74 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java f96209c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 22e5b47 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 4891518 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 8bd24d3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
>   ql/src/test/results/clientnegative/udf_local_resource.q.out 2f2227b 
>   ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out e184787 
>   ql/src/test/results/clientpositive/add_part_multiple.q.out 975baa5 
>   ql/src/test/results/clientpositive/alter2.q.out 3356ab9 
>   ql/src/test/results/clientpositive/alter5.q.out a83b68d 
>   ql/src/test/results/clientpositive/exim_17_part_managed.q.out 9036a28 
> 
> Diff: https://reviews.apache.org/r/26966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message