hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 28864: HIVE-9042 Support multiple mapjoin operators in one work [Spark Branch]
Date Tue, 09 Dec 2014 20:28:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28864/#review64428
-----------------------------------------------------------


Patch looks a good. A test case with multiple map joins in one work would be awesome.


ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java
<https://reviews.apache.org/r/28864/#comment107135>

    There is no need to be "lazy" here. We can just instantiate it here.


- Xuefu Zhang


On Dec. 9, 2014, 7:41 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28864/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 7:41 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-9042
>     https://issues.apache.org/jira/browse/HIVE-9042
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> In one spark work, there could be multiple mapjoin operators, but only one could be bucket
mapjoin.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java
6977abc 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java ef04885

>   ql/src/java/org/apache/hadoop/hive/ql/plan/SparkBucketMapJoinContext.java 2976c3a 
> 
> Diff: https://reviews.apache.org/r/28864/diff/
> 
> 
> Testing
> -------
> 
> Unit test.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message