hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 28786: patch for hive-8673
Date Mon, 08 Dec 2014 02:15:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28786/#review64191
-----------------------------------------------------------


Thank you for your patch. Had a few high level questions. Will take another pass after that.


serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
<https://reviews.apache.org/r/28786/#comment106670>

    please trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106671>

    Please add a space before every variable. For this, please change it to the statement
like the followings: "escaped, escapeChar, false, (byte)0, false,  false, false, false, option);"



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106672>

    Please trim the tailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106673>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106683>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106674>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106681>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106682>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106675>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106684>

    Can you also add some annotations here since you add more parameters for the method "createLazyObjectInspector"?



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106677>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106676>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106753>

    We can move the 'SerDeParameters' class out of 'LazySimpleSerDe.java' and pass in an instance
of so many boolean variable to the 'createLazyObjectInspector' method.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106678>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106679>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106680>

    Please merge the nullSequence with the previous line since it will not exceed the max
length of line(100).



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106685>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106755>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106754>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106759>

    Why set quotechar to (byte)0 here? Also we can create a static default value for the quoteChar
instead of using the 'magic value' here.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106757>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106758>

    Please the trim trailing spaces and avoid use the 'magic value' here.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106760>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106761>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
<https://reviews.apache.org/r/28786/#comment106762>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveChar.java
<https://reviews.apache.org/r/28786/#comment106763>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106692>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106693>

    Do we need two parameters for the head and tail trim option? Maybe we can use one option
'fieldTrim' for triming the surrounding whitespace.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106694>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106695>

    Please add the surrounding whitespaces for '='.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106696>

    Please add the surrounding whitespaces for '='.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106697>

    Please add the surrounding whitespaces for '='.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106698>

    Please add the surrounding whitespaces for '='.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106699>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106701>

    A little bit confusing for the variable name. Better to be 'doubleQuotesAsQuote'.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106700>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106687>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106686>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106688>

    Please change the setter and getter in the name convention "set[your capitalized variable
name]/get[your capitalized variable name]".
    Here turn to getLtrim, getRtrim and getDblQuotesAsQuote.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106764>

    Remove the space please.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106768>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106769>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106770>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106800>

    Please add the surrounding whitespaces for '+'.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106801>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106689>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106802>

    Magic value.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106765>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106690>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106691>

    Please the trim trailing spaces and magic value.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java
<https://reviews.apache.org/r/28786/#comment106804>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java
<https://reviews.apache.org/r/28786/#comment106805>

    We can change the snipets as followings:
    if (!oi.isEscaped() && !oi.isQuoted()) {
      // if the data is not escaped and quoted, simply copy the data.
      data.set(bytes.getData(), start, length);
    }
    
    LazyUtils.copyAndEscapeStringDataToText(bytes.getData(), start, length, oi.getEscapeChar(),
oi.getQuoteChar(),
    escaped, quoted, oi.treatDblQuotesAsQuote(), bytes.getData());



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java
<https://reviews.apache.org/r/28786/#comment106803>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106773>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106772>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106774>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106775>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106776>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106777>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106778>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106779>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106806>

    No need for the brackets.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106780>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106807>

    The length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
<https://reviews.apache.org/r/28786/#comment106808>

    extra space



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
<https://reviews.apache.org/r/28786/#comment106702>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
<https://reviews.apache.org/r/28786/#comment106703>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106705>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106706>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106704>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106707>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106708>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106709>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106710>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106711>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106712>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106713>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106714>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106715>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106716>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106717>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106718>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106719>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106720>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106721>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106722>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106723>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106724>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106725>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106726>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106727>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106728>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveCharObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106729>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveCharObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106730>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveCharObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106731>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106732>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106733>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106734>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106735>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106736>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106737>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106767>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106739>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106738>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106781>

    Magic value.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106740>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106741>

    Maximum line length is 100 and the length of the indent should be set to 2.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/28786/#comment106742>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106782>

    Please add the surrounding whitespaces for '='.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106743>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106744>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106745>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106746>

    Please the trim trailing spaces.



serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
<https://reviews.apache.org/r/28786/#comment106747>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java
<https://reviews.apache.org/r/28786/#comment106783>

    Can we add a test for null value handling here?



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java
<https://reviews.apache.org/r/28786/#comment106748>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106749>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106750>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106784>

    Merge these two lines please.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106751>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106752>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106787>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106790>

    The same as above.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106785>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106786>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106788>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106789>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106791>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106792>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106793>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106795>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106794>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106796>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106797>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106798>

    Please the trim trailing spaces.



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106799>

    Please the trim trailing spaces.


- cheng xu


On Dec. 6, 2014, 8:43 p.m., Ronan Stokes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28786/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 8:43 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: hive-8673
>     https://issues.apache.org/jira/browse/hive-8673
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> patch for hive-8673
> 
> 
> Diffs
> -----
> 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
8d3595b 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java e3968a9 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveChar.java 3799c7c 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java b4659e7 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 95e30db 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java 75b9556 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java 588cc8c 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 3943508 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
1abd8a5 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
9611e9f 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveCharObjectInspector.java
2b0ad15 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
8e7acce 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
08fec77 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java
28a25d6 
>   serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 3d7f11e 
>   serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java cf86973

> 
> Diff: https://reviews.apache.org/r/28786/diff/
> 
> 
> Testing
> -------
> 
> unit tests run and passed.
> 
> Additional unit tests created and passed
> 
> 
> Thanks,
> 
> Ronan Stokes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message