Return-Path: 
 <dev-return-115998-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8D51C10760
	for <apmail-hive-dev-archive@www.apache.org>;
 Mon, 24 Nov 2014 23:59:13 +0000 (UTC)
Received: (qmail 28720 invoked by uid 500); 24 Nov 2014 23:59:13 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 28637 invoked by uid 500); 24 Nov 2014 23:59:13 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 28625 invoked by uid 500); 24 Nov 2014 23:59:13 -0000
Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org
Received: (qmail 28621 invoked by uid 99); 24 Nov 2014 23:59:13 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 23:59:13 +0000
Date: Mon, 24 Nov 2014 23:59:12 +0000 (UTC)
From: "Szehon Ho (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12757521.1416865203000.11272.1416873552978@Atlassian.JIRA>
In-Reply-To: <JIRA.12757521.1416865203000@Atlassian.JIRA>
References: <JIRA.12757521.1416865203000@Atlassian.JIRA>
 <JIRA.12757521.1416865203554@arcas>
Subject: [jira] [Commented] (HIVE-8955) alter partition should check for
 "hive.stats.autogather" in hiveConf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HIVE-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223788#comment-14223788 ] 

Szehon Ho commented on HIVE-8955:
---------------------------------

I see, feel free to submit a patch if you have a test case to repro the issue.  Maybe others with more knowledge of stats can chime in as well.. 

> alter partition should check for "hive.stats.autogather" in hiveConf
> --------------------------------------------------------------------
>
>                 Key: HIVE-8955
>                 URL: https://issues.apache.org/jira/browse/HIVE-8955
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.13.1
>            Reporter: Pankit Thapar
>             Fix For: 0.15.0
>
>
> When alter partition code path is triggered, it should check for the flag "hive.stats.autogather", if it is true, then only updateStats else skip them.
> This is done in append_partition code flow. 
> Is there any specific reason the alter_partition does not respect this conf variable?
> //code snippet : HiveMetastore.java 
>  private Partition append_partition_common(RawStore ms, String dbName, String tableName,
>         List<String> part_vals, EnvironmentContext envContext) throws InvalidObjectException,
>         AlreadyExistsException, MetaException {
> ...
> ....
>         if (HiveConf.getBoolVar(hiveConf, HiveConf.ConfVars.HIVESTATSAUTOGATHER) &&
>             !MetaStoreUtils.isView(tbl)) {
>           MetaStoreUtils.updatePartitionStatsFast(part, wh, madeDir);
>         }
> ...
> ...
> }
> The above code snippet checks for the variable but this same check is absent in 
> //code snippet : HiveAlterHandler.java 
> public Partition alterPartition(final RawStore msdb, Warehouse wh, final String dbname,
>       final String name, final List<String> part_vals, final Partition new_part)
>       throws InvalidOperationException, InvalidObjectException, AlreadyExistsException,
>       MetaException {
> ....
> ...
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)